ci: fix npm napi release #257

YassinEldeeb · 2023-12-28T08:26:55Z

No description provided.

github-actions · 2023-12-28T08:35:47Z

✅ Benchmark Results

     data_received..................: 13 MB   221 kB/s
     data_sent......................: 22 MB   363 kB/s
     http_req_blocked...............: min=990ns    avg=2.92µs   med=2.23µs   max=1.34ms  p(95)=3.24µs   p(99)=8.97µs  
     http_req_connecting............: min=0s       avg=370ns    med=0s       max=1.3ms   p(95)=0s       p(99)=0s      
     http_req_duration..............: min=316.43µs avg=414.23µs med=386.1µs  max=23.81ms p(95)=485.74µs p(99)=681.61µs
       { expected_response:true }...: min=316.43µs avg=414.23µs med=386.1µs  max=23.81ms p(95)=485.74µs p(99)=681.61µs
     ✓ { scenario:rps_1000 }........: min=316.43µs avg=414.23µs med=386.1µs  max=23.81ms p(95)=485.74µs p(99)=681.61µs
     http_req_failed................: 0.00%   ✓ 0           ✗ 60001
     ✓ { scenario:rps_1000 }........: 0.00%   ✓ 0           ✗ 60001
     http_req_receiving.............: min=9.3µs    avg=26.95µs  med=25.83µs  max=7.4ms   p(95)=37µs     p(99)=49.12µs 
     http_req_sending...............: min=6.41µs   avg=15.34µs  med=14.24µs  max=1.66ms  p(95)=23.74µs  p(99)=32.46µs 
     http_req_tls_handshaking.......: min=0s       avg=0s       med=0s       max=0s      p(95)=0s       p(99)=0s      
     http_req_waiting...............: min=276.72µs avg=371.94µs med=344.8µs  max=23.77ms p(95)=443.41µs p(99)=613.13µs
     http_reqs......................: 60001   1000.005923/s
     ✓ { scenario:rps_1000 }........: 60001   1000.005923/s
     iteration_duration.............: min=387.54µs avg=503.43µs med=474.19µs max=24.05ms p(95)=579.94µs p(99)=824.03µs
     iterations.....................: 60001   1000.005923/s
     ✓ { scenario:rps_1000 }........: 60001   1000.005923/s
     valid_graphql_response.........: 100.00% ✓ 60001       ✗ 0    
     ✓ { scenario:rps_1000 }........: 100.00% ✓ 60001       ✗ 0    
     valid_http_code................: 100.00% ✓ 60001       ✗ 0    
     ✓ { scenario:rps_1000 }........: 100.00% ✓ 60001       ✗ 0    
     vus............................: 1       min=0         max=2  
     vus_max........................: 200     min=200       max=200

github-actions · 2023-12-28T09:06:40Z

🐋 This PR was built and pushed to the following Docker images:

Docker Bake metadata

{
"conductor": {
  "containerimage.config.digest": "sha256:4684b32341f4028f4ab39fe9fab14d096f3de5ddd8c5f594b75090e6847ba3c8",
  "containerimage.descriptor": {
    "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
    "digest": "sha256:8bae6b468425def0b5febaa1aca54ddddfc1e62d1b1b63a526d11c8a6263c791",
    "size": 902,
    "platform": {
      "architecture": "amd64",
      "os": "linux"
    }
  },
  "containerimage.digest": "sha256:8bae6b468425def0b5febaa1aca54ddddfc1e62d1b1b63a526d11c8a6263c791",
  "image.name": "ghcr.io/the-guild-org/conductor/conductor:bc2b507b5c9678b7768427e690707b83f9e4d873"
}
}

github-actions · 2024-01-11T13:27:57Z

🚨 Rust Panic Audit: 123 Potential Panic Points Detected 🚨

Crate: `federation_query_planner`

📊 Total Usages: 50

🎁 unwrap usages: 29
🚨 panic usages: 3
🔢 array_index usages: 10
🔎 expect usages: 8

Crate: `jwt_auth`

📊 Total Usages: 45

🎁 unwrap usages: 43
🔢 array_index usages: 2

📌 Expected Annotations

    let client = wasm_polyfills::create_http_client().build().unwrap();: // @expected: if initiating an http client fails, then we have to exit.

Crate: `engine`

📊 Total Usages: 12

🔎 expect usages: 1
🎁 unwrap usages: 8
🚨 panic usages: 3

📌 Expected Annotations

    Err(e) => panic!("failed to construct endpoint: {:?}", e),: // @expected: if we are unable to construct the endpoints and attach them onto the gateway's http server, we have to exit

ConductorGateway::execute(request, &gw.routes[0].route_data).await: // @expected: we can safely index here, it's inside a test with constant defined fixtures.

    panic!(: // @expected: without a fetcher, there's no executor, without an executor, there's no gateway.

        panic!("Failed while initializing the executor's fetcher for Federation source");: // @expected: without a fetcher, there's no executor, without an executor, there's no gateway.

    panic!("Failed while initializing the executor's fetcher for Federation source");: // @expected: without a fetcher, there's no executor, without an executor, there's no gateway.

Crate: `telemetry`

📊 Total Usages: 5

🎁 unwrap usages: 2
🔢 array_index usages: 3

Crate: `conductor`

📊 Total Usages: 3

🔎 expect usages: 1
🚨 panic usages: 1
🎁 unwrap usages: 1

📌 Expected Annotations

  tracing::subscriber::set_global_default(subscriber).expect("failed to set up tracing");: // @expected: we need to exit the process, if the logger can't be correctly set.

  panic!("Failed to initialize gateway: {:?}", e);: // @expected: we need to exit the process, if the provided configuration file is incorrect.

Crate: `tracing`

📊 Total Usages: 3

🎁 unwrap usages: 3

Crate: `vrl`

📊 Total Usages: 3

🔢 array_index usages: 3

📌 Expected Annotations

    panic!("failed to compile vrl program");: // @expected: if the provided VRL code in the config file can't compile, we have to exit.

  .expect("can't merge states when `states` is an empty vector!"): // @expected: `states` is a non-user provided variable

Crate: `cloudflare_worker`

📊 Total Usages: 1

🚨 panic usages: 1

Crate: `config`

📊 Total Usages: 1

🚨 panic usages: 1

📌 Expected Annotations

.unwrap();: // @expected: statically defined regex pattern, we know it works ;)

  panic!("Failed to interpolate config file, please resolve the above errors");: // @expected: 👇

  parse_config_from_json(&config_string).expect("Failed to parse JSON config file"): // @expected: 👇

  parse_config_from_yaml(&config_string).expect("Failed to parse YAML config file"): // @expected: 👇

    _ => panic!("Unsupported config file extension"),: // @expected: 👇

  None => panic!("Config file has no extension"),: // @expected: 👇

.expect("Failed to serialize json schema for config file!");: // @expected: part of development docgen CLI

.expect("Failed to write the json schema to the file system!");: // @expected: part of development docgen CLI

Crate: `trusted_documents`

📊 Total Usages: 0

Crate: `disable_introspection`

📊 Total Usages: 0

📌 Expected Annotations

      panic!("failed to compile vrl program for disable_introspection plugin");: // @expected: we need to exit the process if our provided VRL condition has incorrect syntax.

Crate: `test-server`

📊 Total Usages: 0

Crate: `match_content_type`

📊 Total Usages: 0

Crate: `cors`

📊 Total Usages: 0

Crate: `wasm_polyfills`

📊 Total Usages: 0

Crate: `minitrace_reqwest`

📊 Total Usages: 0

Crate: `logger`

📊 Total Usages: 0

Crate: `common`

📊 Total Usages: 0

📌 Expected Annotations

.unwrap(): // @expected: we're parsing a statically defined constant, we know it works ;)

Crate: `graphiql`

📊 Total Usages: 0

Crate: `napi`

📊 Total Usages: 0

📌 Expected Annotations

panic!("Exited process!"): // @expected: we need this

Crate: `http_get`

📊 Total Usages: 0

YassinEldeeb force-pushed the fix-release-ci branch from 0f0b4e3 to b2ceb29 Compare December 28, 2023 08:55

YassinEldeeb force-pushed the fix-release-ci branch from a523cbc to 35b7883 Compare January 23, 2024 13:43

YassinEldeeb added 10 commits January 24, 2024 14:30

run CI without release

f1a50a8

change name

2786972

modify name

3fc5bad

fix

02c5a97

set working directory

7a4c696

build only mac-win-lin

a2c4abf

fix

d169f7a

remove yarn caching

7c69489

update path

8291782

edit docker run working dir

415fec9

YassinEldeeb force-pushed the fix-release-ci branch from b90e819 to 415fec9 Compare January 24, 2024 12:32

YassinEldeeb added 3 commits January 24, 2024 14:50

fixes

0e3138f

fix docker mounting path

1b17524

remove the testing step

bc2b507

YassinEldeeb changed the title ~~ci: fix release (again)~~ ci: fix npm napi release Jan 24, 2024

dotansimha merged commit 141550e into master Jan 24, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

ci: fix npm napi release #257

ci: fix npm napi release #257

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ci: fix npm napi release #257

ci: fix npm napi release #257

Uh oh!

Conversation

Uh oh!

Uh oh!

✅ Benchmark Results

Uh oh!

Uh oh!

Uh oh!

Uh oh!

🚨 Rust Panic Audit: 123 Potential Panic Points Detected 🚨

Crate: federation_query_planner

Crate: jwt_auth

📌 Expected Annotations

Crate: engine

📌 Expected Annotations

Crate: telemetry

Crate: conductor

📌 Expected Annotations

Crate: tracing

Crate: vrl

📌 Expected Annotations

Crate: cloudflare_worker

Crate: config

📌 Expected Annotations

Crate: trusted_documents

Crate: disable_introspection

📌 Expected Annotations

Crate: test-server

Crate: match_content_type

Crate: cors

Crate: wasm_polyfills

Crate: minitrace_reqwest

Crate: logger

Crate: common

📌 Expected Annotations

Crate: graphiql

Crate: napi

📌 Expected Annotations

Crate: http_get

Uh oh!

Uh oh!

Crate: `federation_query_planner`

Crate: `jwt_auth`

Crate: `engine`

Crate: `telemetry`

Crate: `conductor`

Crate: `tracing`

Crate: `vrl`

Crate: `cloudflare_worker`

Crate: `config`

Crate: `trusted_documents`

Crate: `disable_introspection`

Crate: `test-server`

Crate: `match_content_type`

Crate: `cors`

Crate: `wasm_polyfills`

Crate: `minitrace_reqwest`

Crate: `logger`

Crate: `common`

Crate: `graphiql`

Crate: `napi`

Crate: `http_get`