Update Yoga GraphiQL to latest #431

dotansimha · 2024-02-11T12:54:23Z

closes #393

github-actions · 2024-02-11T12:54:51Z

🚨 Rust Panic Audit: 86 Potential Panic Points Detected 🚨

Crate: `federation_query_planner`

📊 Total Usages: 50

🔎 expect usages: 8
🔢 array_index usages: 10
🚨 panic usages: 3
🎁 unwrap usages: 29

Crate: `engine`

📊 Total Usages: 11

🔎 expect usages: 1
🚨 panic usages: 3
🎁 unwrap usages: 7

Crate: `telemetry`

📊 Total Usages: 9

🔢 array_index usages: 5
🎁 unwrap usages: 4

Crate: `tracing`

📊 Total Usages: 6

🔎 expect usages: 1
🎁 unwrap usages: 5

Crate: `cloudflare_worker`

📊 Total Usages: 6

🎁 unwrap usages: 5
🚨 panic usages: 1

Crate: `conductor`

📊 Total Usages: 3

🚨 panic usages: 1
🎁 unwrap usages: 1
🔎 expect usages: 1

Crate: `config`

📊 Total Usages: 1

🚨 panic usages: 1

📌 Expected Annotations

Crate: `engine`

📊 Total Expected Usages: 5

expand details

Reason: "if we are unable to construct the endpoints and attach them onto the gateway's http server, we have to exit"

Code: Err(e) => panic!("failed to construct endpoint: {:?}", e),
Location: ./libs/engine/src/gateway.rs:145

Reason: "we can safely index here, it's inside a test with constant defined fixtures."

Code: ConductorGateway::execute(request, &gw.routes[0].route_data).await
Location: ./libs/engine/src/gateway.rs:177

Reason: "without a fetcher, there's no executor, without an executor, there's no gateway."

Code: panic!("Failed while initializing the executor's fetcher for Federation source");
Location: ./libs/engine/src/source/federation_source.rs:109

Reason: "without a fetcher, there's no executor, without an executor, 8000 there's no gateway."

Code: panic!("Failed while initializing the executor's fetcher for Federation source");
Location: ./libs/engine/src/source/federation_source.rs:140

Reason: "without a fetcher, there's no executor, without an executor, there's no gateway."

Code: panic!(
Location: ./libs/engine/src/source/graphql_source.rs:30

Crate: `napi`

📊 Total Expected Usages: 1

expand details

Reason: "we need this"

Code: panic!("Exited process!")
Location: ./libs/napi/src/lib.rs:18

Crate: `vrl`

📊 Total Expected Usages: 2

expand details

Reason: "if the provided VRL code in the config file can't compile, we have to exit."

Code: panic!("failed to compile vrl program");
Location: ./plugins/vrl/src/plugin.rs:122

Reason: "states is a non-user provided variable"

Code: .expect("can't merge states when states is an empty vector!")
Location: ./plugins/vrl/src/plugin.rs:139

Crate: `conductor`

📊 Total Expected Usages: 2

expand details

Reason: "we need to exit the process, if the logger can't be correctly set."

Code: tracing::subscriber::set_global_default(subscriber).expect("failed to set up tracing");
Location: ./bin/conductor/src/lib.rs:37

Reason: "we need to exit the process, if the provided configuration file is incorrect."

Code: panic!("Failed to initialize gateway: {:?}", e);
Location: ./bin/conductor/src/lib.rs:75

Crate: `jwt_auth`

📊 Total Expected Usages: 1

expand details

Reason: "if initiating an http client fails, then we have to exit."

Code: let client = wasm_polyfills::create_http_client().build().unwrap();
Location: ./plugins/jwt_auth/src/jwks_provider.rs:49

Crate: `cloudflare_worker`

📊 Total Expected Usages: 4

expand details

Reason: "it panics only if the header name is not valid, and we know it is."

Code: .unwrap()
Location: ./bin/cloudflare_worker/src/http_tracing.rs:20

Reason: "it panics only if the URL source is not valid, and it's already validated before."

Code: let url = req.url().unwrap();
Location: ./bin/cloudflare_worker/src/http_tracing.rs:23

Reason: "it only panics if we are not running in a CF context, should be safe."

Code: let cf_info = req.cf().unwrap();
Location: ./bin/cloudflare_worker/src/http_tracing.rs:27

Reason: "unwraps only in special cases where "data:text" is used."

Code: let http_host = url.host().unwrap().to_string();
Location: ./bin/cloudflare_worker/src/http_tracing.rs:36

Crate: `common`

📊 Total Expected Usages: 1

expand details

Reason: "we're parsing a statically defined constant, we know it works ;)"

Code: .unwrap()
Location: ./libs/common/src/graphql.rs:23

Crate: `config`

📊 Total Expected Usages: 9

expand details

Reason: "statically defined regex pattern, we know it works ;)"

Code: .unwrap();
Location: ./libs/config/src/interpolate.rs:18

Reason: "👇"

Code: let raw_contents = read_to_string(file_path)
Location: ./libs/config/src/lib.rs:576

Reason: "👇"

Code: panic!("Failed to interpolate config file, please resolve the above errors");
Location: ./libs/config/src/lib.rs:608

Reason: "👇"

Code: parse_config_from_json(&config_string).expect("Failed to parse JSON config file")
Location: ./libs/config/src/lib.rs:615

Reason: "👇"

Code: parse_config_from_yaml(&config_string).expect("Failed to parse YAML config file")
Location: ./libs/config/src/lib.rs:619

Reason: "👇"

Code: _ => panic!("Unsupported config file extension"),
Location: ./libs/config/src/lib.rs:636

Reason: "👇"

Code: None => panic!("Config file has no extension"),
Location: ./libs/config/src/lib.rs:639

Reason: "part of development docgen CLI"

Code: .expect("Failed to serialize json schema for config file!");
Location: ./libs/config/src/generate-json-schema.rs:50

Reason: "part of development docgen CLI"

Code: .expect("Failed to write the json schema to the file system!");
Location: ./libs/config/src/generate-json-schema.rs:54

Crate: `disable_introspection`

📊 Total Expected Usages: 1

expand details

Reason: "we need to exit the process if our provided VRL condition has incorrect syntax."

Code: panic!("failed to compile vrl program for disable_introspection plugin");
Location: ./plugins/disable_introspection/src/plugin.rs:33

github-actions · 2024-02-11T13:02:39Z

🐋 This PR was built and pushed to the following Docker images:

Docker Bake metadata

{
"conductor": {
  "containerimage.config.digest": "sha256:a095e397737a74cdaec7964a3c9f7081e4564927961f84091d9da6ad001bd781",
  "containerimage.descriptor": {
    "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
    "digest": "sha256:704d3bde9dec40ec6baa66a17f701ed22ab1bd292bc54bbb1838d13a93c5fa20",
    "size": 902,
    "platform": {
      "architecture": "amd64",
      "os": "linux"
    }
  },
  "containerimage.digest": "sha256:704d3bde9dec40ec6baa66a17f701ed22ab1bd292bc54bbb1838d13a93c5fa20",
  "image.name": "ghcr.io/the-guild-org/conductor/conductor:fac1af8fd8e05c0c4c4c28efd4f5485362519c35"
}
}

github-actions · 2024-02-11T13:03:37Z

✅ Benchmark Results

     data_received..................: 13 MB   221 kB/s
     data_sent......................: 22 MB   363 kB/s
     http_req_blocked...............: min=571ns    avg=2.27µs   med=1.66µs   max=591.39µs p(95)=2.56µs   p(99)=5.57µs  
     http_req_connecting............: min=0s       avg=328ns    med=0s       max=530.16µs p(95)=0s       p(99)=0s      
     http_req_duration..............: min=307.04µs avg=401.35µs med=380.74µs max=21.08ms  p(95)=456.15µs p(99)=523.7µs 
       { expected_response:true }...: min=307.04µs avg=401.35µs med=380.74µs max=21.08ms  p(95)=456.15µs p(99)=523.7µs 
     ✓ { scenario:rps_1000 }........: min=307.04µs avg=401.35µs med=380.74µs max=21.08ms  p(95)=456.15µs p(99)=523.7µs 
     http_req_failed................: 0.00%   ✓ 0          ✗ 60001
     ✓ { scenario:rps_1000 }........: 0.00%   ✓ 0          ✗ 60001
     http_req_receiving.............: min=10.36µs  avg=25.73µs  med=25.4µs   max=2.67ms   p(95)=32.94µs  p(99)=38.51µs 
     http_req_sending...............: min=5.99µs   avg=14.74µs  med=13.49µs  max=1.3ms    p(95)=24.89µs  p(99)=33.44µs 
     http_req_tls_handshaking.......: min=0s       avg=0s       med=0s       max=0s       p(95)=0s       p(99)=0s      
     http_req_waiting...............: min=271.78µs avg=360.88µs med=340.47µs max=21.03ms  p(95)=417.23µs p(99)=477.23µs
     http_reqs......................: 60001   999.994877/s
     ✓ { scenario:rps_1000 }........: 60001   999.994877/s
     iteration_duration.............: min=378.72µs avg=484.82µs med=463.04µs max=21.3ms   p(95)=543.57µs p(99)=659µs   
     iterations.....................: 60001   999.994877/s
     ✓ { scenario:rps_1000 }........: 60001   999.994877/s
     valid_graphql_response.........: 100.00% ✓ 60001      ✗ 0    
     ✓ { scenario:rps_1000 }........: 100.00% ✓ 60001      ✗ 0    
     valid_http_code................: 100.00% ✓ 60001      ✗ 0    
     ✓ { scenario:rps_1000 }........: 100.00% ✓ 60001      ✗ 0    
     vus............................: 2       min=0        max=2  
     vus_max........................: 200     min=200      max=200

Update Yoga GraphiQL to latest

fac1af8

dotansimha merged commit b9e0e0e into master Feb 11, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update Yoga GraphiQL to latest #431

Update Yoga GraphiQL to latest #431

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Update Yoga GraphiQL to latest #431

Update Yoga GraphiQL to latest #431

Uh oh!

Conversation

Uh oh!

🚨 Rust Panic Audit: 86 Potential Panic Points Detected 🚨

Crate: federation_query_planner

Crate: engine

Crate: telemetry

Crate: tracing

Crate: cloudflare_worker

Crate: conductor

Crate: config

📌 Expected Annotations

Crate: engine

Crate: napi

Crate: vrl

Crate: conductor

Crate: jwt_auth

Crate: cloudflare_worker

Crate: common

Crate: config

Crate: disable_introspection

Uh oh!

Uh oh!

✅ Benchmark Results

Uh oh!

Uh oh!

Crate: `federation_query_planner`

Crate: `engine`

Crate: `telemetry`

Crate: `tracing`

Crate: `cloudflare_worker`

Crate: `conductor`

Crate: `config`

Crate: `engine`

Crate: `napi`

Crate: `vrl`

Crate: `conductor`

Crate: `jwt_auth`

Crate: `cloudflare_worker`

Crate: `common`

Crate: `config`

Crate: `disable_introspection`