fix(deps): update rust crate napi to 2.16.1 #539

renovate · 2024-03-26T04:10:46Z

This PR contains the following updates:

Package	Type	Update	Change
napi	dependencies	patch	`2.16.0` -> `2.16.1`

Release Notes

napi-rs/napi-rs (napi)

`v2.16.1`

Compare Source

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

github-actions · 2024-03-26T04:11:16Z

🚨 Rust Panic Audit: 102 Potential Panic Points Detected 🚨

Crate: `federation_query_planner`

📊 Total Usages: 53

🚨 panic usages: 3
🔢 array_index usages: 10
🔎 expect usages: 8
🎁 unwrap usages: 32

Crate: `common`

📊 Total Usages: 11

🔢 array_index usages: 1
🎁 unwrap usages: 10

Crate: `telemetry`

📊 Total Usages: 9

🎁 unwrap usages: 4
🔢 array_index usages: 5

Crate: `cloudflare_worker`

📊 Total Usages: 8

🔎 expect usages: 2
🎁 unwrap usages: 5
🚨 panic usages: 1

Crate: `engine`

📊 Total Usages: 7

🎁 unwrap usages: 6
🔎 expect usages: 1

Crate: `tracing`

📊 Total Usages: 6

🎁 unwrap usages: 5
🔎 expect usages: 1

Crate: `conductor`

📊 Total Usages: 5

🔎 expect usages: 3
🎁 unwrap usages: 1
🚨 panic usages: 1

Crate: `config`

📊 Total Usages: 3

🎁 unwrap usages: 2
🚨 panic usages: 1

📌 Expected Annotations

Crate: `napi`

📊 Total Expected Usages: 1

expand details

Reason: "we need this"

Code: panic!("Exited process!")
Location: ./libs/napi/src/lib.rs:18

Crate: `conductor`

📊 Total Expected Usages: 2

expand details

Reason: "we need to exit the process, if the logger can't be correctly set."

Code: let _guard = tracing::subscriber::set_default(subscriber);
Location: ./bin/conductor/src/lib.rs:37

Reason: "we need to exit the process, if the provided configuration file is incorrect."

Code: panic!("Failed to initialize gateway: {:?}", e);
Location: ./bin/conductor/src/lib.rs:76

Crate: `cloudflare_worker`

📊 Total Expected Usages: 4

expand details

Reason: "it panics only if the header name is not valid, and we know it is."

Code: .unwrap()
Location: ./bin/cloudflare_worker/src/http_tracing.rs:20

Reason: "it panics only if the URL source is not valid, and it's already validated before."

Code: let url = req.url().unwrap();
Location: ./bin/cloudflare_worker/src/http_tracing.rs:23

Reason: "it only panics if we are not running in a CF context, should be safe."

Code: let cf_info = req.cf().unwrap();
Location: ./bin/cloudflare_worker/src/http_tracing.rs:27

Reason: "unwraps only in special cases where "data:text" is used."

Code: let http_host = url.host().unwrap().to_string();
Location: ./bin/cloudflare_worker/src/http_tracing.rs:36

Crate: `config`

📊 Total Expected Usages: 9

expand details

Reason: "👇"

Code: let raw_contents = read_to_string(file_path)
Location: ./libs/config/src/lib.rs:815

Reason: "👇"

Code: panic!("Failed to interpolate config file, please resolve the above errors");
Location: ./libs/config/src/lib.rs:847

Reason: "👇"

Code: parse_config_from_json(&config_string).expect("Failed to parse JSON config file")
Location: ./libs/config/src/lib.rs:854

Reason: "👇"

Code: parse_config_from_yaml(&config_string).expect("Failed to parse YAML config file")
Location: ./libs/config/src/lib.rs:858

Reason: "👇"

Code: _ => panic!("Unsupported config file extension"),
Location: ./libs/config/src/lib.rs:875

Reason: "👇"

Code: None => panic!("Config file has no extension"),
Location: ./libs/config/src/lib.rs:878

Reason: "statically defined regex pattern, we know it works ;)"

Code: .unwrap();
Location: ./libs/config/src/interpolate.rs:18

Reason: "part of development docgen CLI"

Code: .expect("Failed to serialize json schema for config file!");
Location: ./libs/config/src/generate-json-schema.rs:50

Reason: "part of development docgen CLI"

Code: .expect("Failed to write the json schema to the file system!");
Location: ./libs/config/src/generate-json-schema.rs:54

Crate: `common`

📊 Total Expected Usages: 1

expand details

Reason: "we're parsing a statically defined constant, we know it works ;)"

Code: .unwrap()
Location: ./libs/common/src/graphql.rs:31

Crate: `vrl`

📊 Total Expected Usages: 2

expand details

Reason: "if the provided VRL code in the config file can't compile, we have to exit."

Code: panic!("failed to compile vrl program");
Location: ./plugins/vrl/src/plugin.rs:129

Reason: "states is a non-user provided variable"

Code: .expect("can't merge states when states is an empty vector!")
Location: ./plugins/vrl/src/plugin.rs:146

Crate: `engine`

📊 Total Expected Usages: 2

expand details

Reason: "if we are unable to construct the endpoints and attach them onto the gateway's http server, we have to exit"

Code: Err(e) => panic!("failed to construct endpoint: {:?}", e),
Location: ./libs/engine/src/gateway.rs:158

Reason: "we can safely index here, it's inside a test with constant defined fixtures."

Code: ConductorGateway::execute(request, &gw.routes[0].route_data).await
Location: ./libs/engine/src/gateway.rs:190

Crate: `jwt_auth`

📊 Total Expected Usages: 1

expand details

Reason: "if initiating an http client fails, then we have to exit."

Code: let client = wasm_polyfills::create_http_client().build().unwrap();
Location: ./plugins/jwt_auth/src/jwks_provider.rs:49

github-actions · 2024-03-26T04:18:53Z

🐋 This PR was built and pushed to the following Docker images:

Docker Bake metadata

{
"conductor": {
  "buildx.build.ref": "builder-fcf1f21c-9d3b-4094-900a-7a76f1395b33/builder-fcf1f21c-9d3b-4094-900a-7a76f1395b330/my0atmwandf44aomn6o498nym",
  "containerimage.config.digest": "sha256:0f72b5e13b37899b78a4b5439ff4ae200f33f561245a864533df5b2bd9c43a5f",
  "containerimage.descriptor": {
    "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
    "digest": "sha256:1ea4837cd8250d40c3208a99eeeac717f1d84528f3b8734d4b29ac4aba50d84f",
    "size": 902,
    "platform": {
      "architecture": "amd64",
      "os": "linux"
    }
  },
  "containerimage.digest": "sha256:1ea4837cd8250d40c3208a99eeeac717f1d84528f3b8734d4b29ac4aba50d84f",
  "image.name": "ghcr.io/the-guild-org/conductor/conductor:ce68d56e2b498aa8df7370f73ba052ec8d0c2484"
}
}

github-actions · 2024-03-26T04:19:46Z

✅ Benchmark Results

     data_received..................: 13 MB   221 kB/s
     data_sent......................: 22 MB   363 kB/s
     http_req_blocked...............: min=622ns    avg=2.19µs   med=1.57µs   max=622.18µs p(95)=2.48µs   p(99)=3.99µs  
     http_req_connecting............: min=0s       avg=327ns    med=0s       max=317.78µs p(95)=0s       p(99)=0s      
     http_req_duration..............: min=306.39µs avg=398.87µs med=377.99µs max=16.38ms  p(95)=460.49µs p(99)=524.59µs
       { expected_response:true }...: min=306.39µs avg=398.87µs med=377.99µs max=16.38ms  p(95)=460.49µs p(99)=524.59µs
     ✓ { scenario:rps_1000 }........: min=306.39µs avg=398.87µs med=377.99µs max=16.38ms  p(95)=460.49µs p(99)=524.59µs
     http_req_failed................: 0.00%   ✓ 0           ✗ 60001
     ✓ { scenario:rps_1000 }........: 0.00%   ✓ 0           ✗ 60001
     http_req_receiving.............: min=9.68µs   avg=25.67µs  med=25.25µs  max=1.3ms    p(95)=33.7µs   p(99)=43.79µs 
     http_req_sending...............: min=5.44µs   avg=14.24µs  med=13.07µs  max=1ms      p(95)=23.21µs  p(99)=30.96µs 
     http_req_tls_handshaking.......: min=0s       avg=0s       med=0s       max=0s       p(95)=0s       p(99)=0s      
     http_req_waiting...............: min=271.94µs avg=358.95µs med=338.27µs max=16.32ms  p(95)=422.64µs p(99)=480.97µs
     http_reqs......................: 60001   1000.006722/s
     ✓ { scenario:rps_1000 }........: 60001   1000.006722/s
     iteration_duration.............: min=376.27µs avg=479.84µs med=458.35µs max=16.63ms  p(95)=544.66µs p(99)=650.35µs
     iterations.....................: 60001   1000.006722/s
     ✓ { scenario:rps_1000 }........: 60001   1000.006722/s
     valid_graphql_response.........: 100.00% ✓ 60001       ✗ 0    
     ✓ { scenario:rps_1000 }........: 100.00% ✓ 60001       ✗ 0    
     valid_http_code................: 100.00% ✓ 60001       ✗ 0    
     ✓ { scenario:rps_1000 }........: 100.00% ✓ 60001       ✗ 0    
     vus............................: 1       min=0         max=2  
     vus_max........................: 200     min=200       max=200

dotansimha enabled auto-merge (squash) March 26, 2024 08:01

fix(deps): update rust crate napi to 2.16.1

ce68d56

renovate bot force-pushed the renovate/napi-2.x branch from 47edee3 to ce68d56 Compare March 26, 2024 08:03

dotansimha merged commit 46aed4a into master Mar 26, 2024

renovate bot deleted the renovate/napi-2.x branch March 26, 2024 08:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(deps): update rust crate napi to 2.16.1 #539

fix(deps): update rust crate napi to 2.16.1 #539

fix(deps): update rust crate napi to 2.16.1 #539

fix(deps): update rust crate napi to 2.16.1 #539

Conversation

Release Notes

v2.16.1

Configuration

🚨 Rust Panic Audit: 102 Potential Panic Points Detected 🚨

Crate: federation_query_planner

Crate: common

Crate: telemetry

Crate: cloudflare_worker

Crate: engine

Crate: tracing

Crate: conductor

Crate: config

📌 Expected Annotations

Crate: napi

Crate: conductor

Crate: cloudflare_worker

Crate: config

Crate: common

Crate: vrl

Crate: engine

Crate: jwt_auth

✅ Benchmark Results

`v2.16.1`

Crate: `federation_query_planner`

Crate: `common`

Crate: `telemetry`

Crate: `cloudflare_worker`

Crate: `engine`

Crate: `tracing`

Crate: `conductor`

Crate: `config`

Crate: `napi`

Crate: `conductor`

Crate: `cloudflare_worker`

Crate: `config`

Crate: `common`

Crate: `vrl`

Crate: `engine`

Crate: `jwt_auth`