fix(deps): update rust crate opentelemetry-http to 0.11.1 #554

renovate · 2024-04-08T16:32:18Z

This PR contains the following updates:

Package	Type	Update	Change
opentelemetry-http	dependencies	patch	`0.11.0` -> `0.11.1`

Release Notes

open-telemetry/opentelemetry-rust (opentelemetry-http)

`v0.11.1`

Compare Source

Fixed

Fix remote implicit builder context sampling #405

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

github-actions · 2024-04-08T16:32:43Z

🚨 Rust Panic Audit: 102 Potential Panic Points Detected 🚨

Crate: `federation_query_planner`

📊 Total Usages: 53

🎁 unwrap usages: 32
🔎 expect usages: 8
🔢 array_index usages: 10
🚨 panic usages: 3

Crate: `common`

📊 Total Usages: 11

🔢 array_index usages: 1
🎁 unwrap usages: 10

Crate: `telemetry`

📊 Total Usages: 9

🔢 array_index usages: 5
🎁 unwrap usages: 4

Crate: `cloudflare_worker`

📊 Total Usages: 8

🎁 unwrap usages: 5
🔎 expect usages: 2
🚨 panic usages: 1

Crate: `engine`

📊 Total Usages: 7

🔎 expect usages: 1
🎁 unwrap usages: 6

Crate: `tracing`

📊 Total Usages: 6

🎁 unwrap usages: 5
🔎 expect usages: 1

Crate: `conductor`

📊 Total Usages: 5

🚨 panic usages: 1
🎁 unwrap usages: 1
🔎 expect usages: 3

Crate: `config`

📊 Total Usages: 3

🎁 unwrap usages: 2
🚨 panic usages: 1

📌 Expected Annotations

Crate: `napi`

📊 Total Expected Usages: 1

expand details

Reason: "we need this"

Code: panic!("Exited process!")
Location: ./libs/napi/src/lib.rs:18

Crate: `cloudflare_worker`

📊 Total Expected Usages: 4

expand details

Reason: "it panics only if the header name is not valid, and we know it is."

Code: .unwrap()
Location: ./bin/cloudflare_worker/src/http_tracing.rs:20

Reason: "it panics only if the URL source is not valid, and it's already validated before."

Code: let url = req.url().unwrap();
Location: ./bin/cloudflare_worker/src/http_tracing.rs:23

Reason: "it only panics if we are not running in a CF context, should be safe."

Code: let cf_info = req.cf().unwrap();
Location: ./bin/cloudflare_worker/src/http_tracing.rs:27

Reason: "unwraps only in special cases where "data:text" is used."

Code: let http_host = url.host().unwrap().to_string();
Location: ./bin/cloudflare_worker/src/http_tracing.rs:36

Crate: `jwt_auth`

📊 Total Expected Usages: 1

expand details

Reason: "if initiating an http client fails, then we have to exit."

Code: let client = wasm_polyfills::create_http_client().build().unwrap();
Location: ./plugins/jwt_auth/src/jwks_provider.rs:49

Crate: `engine`

📊 Total Expected Usages: 2

expand details

Reason: "if we are unable to construct the endpoints and attach them onto the gateway's http server, we have to exit"

Code: Err(e) => panic!("failed to construct endpoint: {:?}", e),
Location: ./libs/engine/src/gateway.rs:158

Reason: "we can safely index here, it's inside a test with constant defined fixtures."

Code: ConductorGateway::execute(request, &gw.routes[0].route_data).await
Location: ./libs/engine/src/gateway.rs:190

Crate: `vrl`

📊 Total Expected Usages: 2

expand details

Reason: "if the provided VRL code in the config file can't compile, we have to exit."

Code: panic!("failed to compile vrl program");
Location: ./plugins/vrl/src/plugin.rs:129

Reason: "states is a non-user provided variable"

Code: .expect("can't merge states when states is an empty vector!")
Location: ./plugins/vrl/src/plugin.rs:146

Crate: `conductor`

📊 Total Expected Usages: 2

expand details

Reason: "we need to exit the process, if the logger can't be correctly set."

Code: let _guard = tracing::subscriber::set_default(subscriber);
Location: ./bin/conductor/src/lib.rs:37

Reason: "we need to exit th 8000 e process, if the provided configuration file is incorrect."

Code: panic!("Failed to initialize gateway: {:?}", e);
Location: ./bin/conductor/src/lib.rs:76

Crate: `config`

📊 Total Expected Usages: 9

expand details

Reason: "part of development docgen CLI"

Code: .expect("Failed to serialize json schema for config file!");
Location: ./libs/config/src/generate-json-schema.rs:50

Reason: "part of development docgen CLI"

Code: .expect("Failed to write the json schema to the file system!");
Location: ./libs/config/src/generate-json-schema.rs:54

Reason: "👇"

Code: let raw_contents = read_to_string(file_path)
Location: ./libs/config/src/lib.rs:815

Reason: "👇"

Code: panic!("Failed to interpolate config file, please resolve the above errors");
Location: ./libs/config/src/lib.rs:847

Reason: "👇"

Code: parse_config_from_json(&config_string).expect("Failed to parse JSON config file")
Location: ./libs/config/src/lib.rs:854

Reason: "👇"

Code: parse_config_from_yaml(&config_string).expect("Failed to parse YAML config file")
Location: ./libs/config/src/lib.rs:858

Reason: "👇"

Code: _ => panic!("Unsupported config file extension"),
Location: ./libs/config/src/lib.rs:875

Reason: "👇"

Code: None => panic!("Config file has no extension"),
Location: ./libs/config/src/lib.rs:878

Reason: "statically defined regex pattern, we know it works ;)"

Code: .unwrap();
Location: ./libs/config/src/interpolate.rs:18

Crate: `common`

📊 Total Expected Usages: 1

expand details

Reason: "we're parsing a statically defined constant, we know it works ;)"

Code: .unwrap()
Location: ./libs/common/src/graphql.rs:31

github-actions · 2024-04-08T16:40:44Z

🐋 This PR was built and pushed to the following Docker images:

Docker Bake metadata

{
"conductor": {
  "buildx.build.ref": "builder-f6c548fd-5f17-488b-ad8a-4e2fa39991ff/builder-f6c548fd-5f17-488b-ad8a-4e2fa39991ff0/xpgm5425sw1l29nzrm1dvvdy0",
  "containerimage.config.digest": "sha256:6b89ce97398601600ed43eedb643fa16acc880eddfcfc4c22780a42fc5300a15",
  "containerimage.descriptor": {
    "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
    "digest": "sha256:713ccf53ffd63bd050b8bd1866b6bcf34b8f89cc3f71727f813bd24237284d83",
    "size": 902,
    "platform": {
      "architecture": "amd64",
      "os": "linux"
    }
  },
  "containerimage.digest": "sha256:713ccf53ffd63bd050b8bd1866b6bcf34b8f89cc3f71727f813bd24237284d83",
  "image.name": "ghcr.io/the-guild-org/conductor/conductor:a11bb842ddb9a4564a7609da079b5351f9bb6133"
}
}

github-actions · 2024-04-08T16:41:26Z

✅ Benchmark Results

     data_received..................: 13 MB   221 kB/s
     data_sent......................: 22 MB   363 kB/s
     http_req_blocked...............: min=1.03µs   avg=3.17µs   med=2.15µs   max=7.7ms   p(95)=3.13µs   p(99)=10.29µs 
     http_req_connecting............: min=0s       avg=663ns    med=0s       max=7.66ms  p(95)=0s       p(99)=0s      
     http_req_duration..............: min=308.69µs avg=407.85µs med=383.14µs max=19.54ms p(95)=475.87µs p(99)=580.14µs
       { expected_response:true }...: min=308.69µs avg=407.85µs med=383.14µs max=19.54ms p(95)=475.87µs p(99)=580.14µs
     ✓ { scenario:rps_1000 }........: min=308.69µs avg=407.85µs med=383.14µs max=19.54ms p(95)=475.87µs p(99)=580.14µs
     http_req_failed................: 0.00%   ✓ 0           ✗ 60002
     ✓ { scenario:rps_1000 }........: 0.00%   ✓ 0           ✗ 60002
     http_req_receiving.............: min=10.05µs  avg=26.15µs  med=25.59µs  max=1.09ms  p(95)=33.68µs  p(99)=40.84µs 
     http_req_sending...............: min=6.68µs   avg=15.3µs   med=13.99µs  max=1.26ms  p(95)=24.72µs  p(99)=33.25µs 
     http_req_tls_handshaking.......: min=0s       avg=0s       med=0s       max=0s      p(95)=0s       p(99)=0s      
     http_req_waiting...............: min=275.26µs avg=366.39µs med=342.55µs max=19.48ms p(95)=434.63µs p(99)=531.19µs
     http_reqs......................: 60002   1000.002718/s
     ✓ { scenario:rps_1000 }........: 60002   1000.002718/s
     iteration_duration.............: min=379.9µs  avg=493.81µs med=467.26µs max=19.76ms p(95)=564.42µs p(99)=735.52µs
     iterations.....................: 60002   1000.002718/s
     ✓ { scenario:rps_1000 }........: 60002   1000.002718/s
     valid_graphql_response.........: 100.00% ✓ 60002       ✗ 0    
     ✓ { scenario:rps_1000 }........: 100.00% ✓ 60002       ✗ 0    
     valid_http_code................: 100.00% ✓ 60002       ✗ 0    
     ✓ { scenario:rps_1000 }........: 100.00% ✓ 60002       ✗ 0    
     vus............................: 1       min=0         max=2  
     vus_max........................: 200     min=200       max=200

fix(deps): update rust crate opentelemetry-http to 0.11.1

a11bb84

dotansimha merged commit 3c32730 into master Apr 10, 2024
14 checks passed

renovate bot deleted the renovate/opentelemetry-rust branch April 10, 2024 08:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(deps): update rust crate opentelemetry-http to 0.11.1 #554

fix(deps): update rust crate opentelemetry-http to 0.11.1 #554

fix(deps): update rust crate opentelemetry-http to 0.11.1 #554

fix(deps): update rust crate opentelemetry-http to 0.11.1 #554

Conversation

Release Notes

v0.11.1

Fixed

Configuration

🚨 Rust Panic Audit: 102 Potential Panic Points Detected 🚨

Crate: federation_query_planner

Crate: common

Crate: telemetry

Crate: cloudflare_worker

Crate: engine

Crate: tracing

Crate: conductor

Crate: config

📌 Expected Annotations

Crate: napi

Crate: cloudflare_worker

Crate: jwt_auth

Crate: engine

Crate: vrl

Crate: conductor

Crate: config

Crate: common

✅ Benchmark Results

`v0.11.1`

Crate: `federation_query_planner`

Crate: `common`

Crate: `telemetry`

Crate: `cloudflare_worker`

Crate: `engine`

Crate: `tracing`

Crate: `conductor`

Crate: `config`

Crate: `napi`

Crate: `cloudflare_worker`

Crate: `jwt_auth`

Crate: `engine`

Crate: `vrl`

Crate: `conductor`

Crate: `config`

Crate: `common`