8000 Feat(core): InputProps should inherit from built-in ones by thien-do · Pull Request #239 · thien-do/moai · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Feat(core): InputProps should inherit from built-in ones #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 29, 2021
Merged

Feat(core): InputProps should inherit from built-in ones #239

merged 3 commits into from
Jun 29, 2021

Conversation

thien-do
Copy link
Owner
@thien-do thien-do commented Jun 28, 2021 •
edited
Loading

Fix #160 Fix #159 , big thank to @monodyle

@vercel
Copy link
vercel bot commented Jun 28, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

moai-docs – ./lib/docs

🔍 Inspect: https://vercel.com/makeinvietnam/moai-docs/AVHNM2YNz7FFq8FTYyKUJhzuYnpV
✅ Preview: https://moai-docs-git-fork-thien-do-input-props-makeinvietnam.vercel.app

moai-site – ./site

🔍 Inspect: https://vercel.com/makeinvietnam/moai-site/D947aFNDkuy22pYswo4bQez2rztg
✅ Preview: https://moai-site-git-fork-thien-do-input-props-makeinvietnam.vercel.app

@thien-do thien-do requested a review from monodyle June 28, 2021 21:21
@thien-do thien-do mentioned this pull request Jun 28, 2021
Closed
@thien-do thien-do assigned lqt93, tuhuynh27 and monodyle and unassigned lqt93, tuhuynh27 and monodyle Jun 28, 2021
lqt93
lqt93 approved these changes Jun 29, 2021
View reviewed changes
Copy link
Contributor
@lqt93 lqt93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

monodyle
monodyle approved these changes Jun 29, 2021
View reviewed changes
Copy link
Contributor
@monodyle monodyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOTM

@thien-do thien-do merged commit a0d2bb2 into thien-do:main Jun 29, 2021
@thien-do thien-do deleted the input-props branch June 29, 2021 04:55
@thien-do thien-do mentioned this pull request Jun 30, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lqt93 lqt93 lqt93 approved these changes

@monodyle monodyle monodyle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Component interface should be based (extend) on default HTML element attributes Input component should have "autoComplete" prop
4 participants
@thien-do @lqt93 @monodyle @tuhuynh27
0