10000 Chore(core): Improve props extending in Input by thien-do · Pull Request #247 · thien-do/moai · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Chore(core): Improve props extending in Input #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 3, 2021
Merged

Chore(core): Improve props extending in Input #247

merged 2 commits into from
Jul 3, 2021

Conversation

thien-do
Copy link
Owner
@thien-do thien-do commented Jul 3, 2021

Follow up of #245

@thien-do thien-do requested a review from lqt93 July 3, 2021 02:52
@vercel
Copy link
vercel bot commented Jul 3, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

moai-docs – ./lib/docs

🔍 Inspect: https://vercel.com/makeinvietnam/moai-docs/GKYxrD3FnH2PTBgHxc14GaeAy775
✅ Preview: https://moai-docs-git-fork-thien-do-input-props-2-makeinvietnam.vercel.app

moai-site – ./site

🔍 Inspect: https://vercel.com/makeinvietnam/moai-site/GVgEkjcb3oGEVDTFiAvTNhZNPn1o
✅ Preview: https://moai-site-git-fork-thien-do-input-props-2-makeinvietnam.vercel.app

@thien-do thien-do changed the title Chore(core): Improve props extending Chore(core): Improve props extending in Input Jul 3, 2021
lqt93
lqt93 approved these changes Jul 3, 2021
View reviewed changes
Copy link
Contributor
@lqt93 lqt93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thien-do thien-do merged commit 96b7a96 into thien-do:main Jul 3, 2021
@thien-do thien-do deleted the input-props-2 branch July 3, 2021 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lqt93 lqt93 lqt93 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thien-do @lqt93
0