8000 Account factory: update constructor params by kumaryash90 · Pull Request #556 · thirdweb-dev/contracts · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Account factory: update constructor params #556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 26, 2023
Merged

Account factory: update constructor params #556

merged 2 commits into from
Oct 26, 2023

Conversation

kumaryash90
Copy link
Member

Remove msg.sender. Take _defaultAdmin as input to constructor.

@nkrishang nkrishang enabled auto-merge (squash) October 26, 2023 16:34
@nkrishang nkrishang disabled auto-merge October 26, 2023 16:42
@codecov
Copy link
codecov bot commented Oct 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
...rebuilts/account/dynamic/DynamicAccountFactory.sol 50.00% <ø> (+50.00%) ⬆️
...rebuilts/account/managed/ManagedAccountFactory.sol 66.66% <ø> (ø)
...ebuilts/account/non-upgradeable/AccountFactory.sol 50.00% <ø> (ø)

📢 Thoughts on this report? Let us know!.

@kumaryash90 kumaryash90 merged commit cb0f1da into main Oct 26, 2023
@kumaryash90 kumaryash90 deleted the yash/accountfactory-constructor-params branch October 26, 2023 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkrishang nkrishang Awaiting requested review from nkrishang

@joaquim-verges joaquim-verges Awaiting requested review from joaquim-verges

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kumaryash90
0