8000 Solidity SDK ERC1155 by nkrishang · Pull Request #206 · thirdweb-dev/contracts · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Solidity SDK ERC1155 #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 27 commits into from
Aug 12, 2022
Merged

Solidity SDK ERC1155 #206

merged 27 commits into from
Aug 12, 2022

Conversation

nkrishang
Copy link
Contributor

No description provided.

@nkrishang nkrishang self-assigned this Aug 11, 2022
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 11, 2022
View reviewed changes
contracts/base/ERC1155Base.sol
8000
uint256 nextIdToMint = nextTokenIdToMint();
uint256 startNextIdToMint = nextIdToMint;

uint256 numOfNewNFTs;

Check warning

Code scanning / Slither

Uninitialized local variables

ERC1155Base.batchMintTo(address,uint256[],uint256[],string).numOfNewNFTs (contracts/base/ERC1155Base.sol#143) is a local variable never initialized
contracts/base/ERC1155Base.sol
STATE VARIABLES
//////////////////////////////////////////////////////////////*/

uint256 internal nextTokenIdToMint_;

Check warning

Code scanning / Slither

Unused state variable

ERC1155Base.nextTokenIdToMint_ (contracts/base/ERC1155Base.sol#39) is never used in ERC1155DelayedReveal (contracts/base/ERC1155DelayedReveal.sol#25-114)
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 11, 2022
View reviewed changes
contracts/base/ERC1155Base.sol
* @param _amount The amount of the NFT to burn.
*/
function burn(
address _owner,

Check notice

Code scanning / Slither

Local variable shadowing

ERC1155Base.burn(address,uint256,uint256)._owner (contracts/base/ERC1155Base.sol#172) shadows: - Ownable._owner (contracts/extension/Ownable.sol#15) (state variable)
contracts/base/ERC1155Base.sol
* @param _amounts The amounts of the NFTs to burn.
*/
function burnBatch(
address _owner,

Check notice

Code scanning / Slither

Local variable shadowing

ERC1155Base.burnBatch(address,uint256[],uint256[])._owner (contracts/base/ERC1155Base.sol#192) shadows: - Ownable._owner (contracts/extension/Ownable.sol#15) (state variable)
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 12, 2022
View reviewed changes
contracts/eip/ERC1155.sol
) private {
if (to.code.length > 0) {
try IERC1155Receiver(to).onERC1155BatchReceived(operator, from, ids, amounts, data) returns (
bytes4 response

Check warning

Code scanning / Slither

Uninitialized local variables

ERC1155._doSafeBatchTransferAcceptanceCheck(address,address,address,uint256[],uint256[],bytes).response (contracts/eip/ERC1155.sol#291) is a local variable never initialized
contracts/eip/ERC1155.sol
if (response != IERC1155Receiver.onERC1155Received.selector) {
revert("TOKENS_REJECTED");
}
} catch Error(string memory reason) {

Check warning

Code scanning / Slither

Uninitialized local variables

ERC1155._doSafeTransferAcceptanceCheck(address,address,address,uint256,uint256,bytes).reason (contracts/eip/ERC1155.sol#273) is a local variable never initialized
contracts/eip/ERC1155.sol
if (response != IERC1155Receiver.onERC1155BatchReceived.selector) {
revert("TOKENS_REJECTED");
}
} catch Error(string memory reason) {

Check warning

Code scanning / Slither

Uninitialized local variables

ERC1155._doSafeBatchTransferAcceptanceCheck(address,address,address,uint256[],uint256[],bytes).reason (contracts/eip/ERC1155.sol#296) is a local variable never initialized
contracts/eip/ERC1155.sol
bytes memory data
) private {
if (to.code.length > 0) {
try IERC1155Receiver(to).onERC1155Received(operator, from, id, amount, data) returns (bytes4 response) {

Check warning

Code scanning / Slither

Uninitialized local variables

ERC1155._doSafeTransferAcceptanceCheck(address,address,address,uint256,uint256,bytes).response (contracts/eip/ERC1155.sol#269) is a local variable never initialized
contracts/eip/ERC1155.sol
Comment on lines +260 to +279
function _doSafeTransferAcceptanceCheck(
address operator,
address from,
address to,
uint256 id,
uint256 amount,
bytes memory data
) private {
if (to.code.length > 0) {
try IERC1155Receiver(to).onERC1155Received(operator, from, id, amount, data) returns (bytes4 response) {
if (response != IERC1155Receiver.onERC1155Received.selector) {
revert("TOKENS_REJECTED");
}
} catch Error(string memory reason) {
revert(reason);
} catch {
revert("!ERC1155RECEIVER");
}
}
}

Check warning

Code scanning / Slither

Unused return

ERC1155._doSafeTransferAcceptanceCheck(address,address,address,uint256,uint256,bytes) (contracts/eip/ERC1155.sol#260-279) ignores return value by IERC1155Receiver(to).onERC1155Received(operator,from,id,amount,data) (contracts/eip/ERC1155.sol#269-277)
contracts/eip/ERC1155.sol
Comment on lines +281 to +302
function _doSafeBatchTransferAcceptanceCheck(
address operator,
address from,
address to,
uint256[] memory ids,
uint256[] memory amounts,
bytes memory data
) private {
if (to.code.length > 0) {
try IERC1155Receiver(to).onERC1155BatchReceived(operator, from, ids, amounts, data) returns (
bytes4 response
) {
if (response != IERC1155Receiver.onERC1155BatchReceived.selector) {
revert("TOKENS_REJECTED");
}
} catch Error(string memory reason) {
revert(reason);
} catch {
revert("!ERC1155RECEIVER");
}
}
}

Check warning

Code scanning / Slither

Unused return

ERC1155._doSafeBatchTransferAcceptanceCheck(address,address,address,uint256[],uint256[],bytes) (contracts/eip/ERC1155.sol#281-302) ignores return value by IERC1155Receiver(to).onERC1155BatchReceived(operator,from,ids,amounts,data) (contracts/eip/ERC1155.sol#290-300)
contracts/eip/ERC1155.sol
if (response != IERC1155Receiver.onERC1155Received.selector) {
revert("TOKENS_REJECTED");
}
} catch Error(string memory reason) {

Check notice

Code scanning / Slither

Pre-declaration usage of local variables

Variable 'ERC1155._doSafeTransferAcceptanceCheck(address,address,address,uint256,uint256,bytes).reason (contracts/eip/ERC1155.sol#273)' in ERC1155._doSafeTransferAcceptanceCheck(address,address,address,uint256,uint256,bytes) (contracts/eip/ERC1155.sol#260-279) potentially used before declaration: revert(string)(reason) (contracts/eip/ERC1155.sol#274)
contracts/eip/ERC1155.sol
bytes memory data
) private {
if (to.code.length > 0) {
try IERC1155Receiver(to).onERC1155Received(operator, from, id, amount, data) returns (bytes4 response) {

Check notice

Code scanning / Slither

Pre-declaration usage of local variables

Variable 'ERC1155._doSafeTransferAcceptanceCheck(address,address,address,uint256,uint256,bytes).response (contracts/eip/ERC1155.sol#269)' in ERC1155._doSafeTransferAcceptanceCheck(address,address,address,uint256,uint256,bytes) (contracts/eip/ERC1155.sol#260-279) potentially used before declaration: response != IERC1155Receiver.onERC1155Received.selector (contracts/eip/ERC1155.sol#270)
contracts/eip/ERC1155.sol
if (response != IERC1155Receiver.onERC1155BatchReceived.selector) {
revert("TOKENS_REJECTED");
}
} catch Error(string memory reason) {

Check notice

Code scanning / Slither

Pre-declaration usage of local variables

Variable 'ERC1155._doSafeBatchTransferAcceptanceCheck(address,address,address,uint256[],uint256[],bytes).reason (contracts/eip/ERC1155.sol#296)' in ERC1155._doSafeBatchTransferAcceptanceCheck(address,address,address,uint256[],uint256[],bytes) (contracts/eip/ERC1155.sol#281-302) potentially used before declaration: revert(string)(reason) (contracts/eip/ERC1155.sol#297)
contracts/eip/ERC1155.sol
) private {
if (to.code.length > 0) {
try IERC1155Receiver(to).onERC1155BatchReceived(operator, from, ids, amounts, data) returns (
bytes4 response

Check notice

Code scanning / Slither

Pre-declaration usage of local variables

Variable 'ERC1155._doSafeBatchTransferAcceptanceCheck(address,address,address,uint256[],uint256[],bytes).response (contracts/eip/ERC1155.sol#291)' in ERC1155._doSafeBatchTransferAcceptanceCheck(address,address,address,uint256[],uint256[],bytes) (contracts/eip/ERC1155.sol#281-302) potentially used before declaration: response != IERC1155Receiver.onERC1155BatchReceived.selector (contracts/eip/ERC1155.sol#293)
@nkrishang nkrishang merged commit 971ceb2 into main Aug 12, 2022
@kumaryash90 kumaryash90 deleted the contracts-sdk-erc1155 branch September 4, 2022 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaquim-verges joaquim-verges Awaiting requested review from joaquim-verges

Assignees

@nkrishang nkrishang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nkrishang
0