Gasless ContractPublisher without chainid in typehash #235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
September 2, 2022 14:24
Comment on lines
+56
to
+81
| function execute(ForwardRequest calldata req, bytes calldata signature) | ||
| public | ||
| payable | ||
| returns (bool, bytes memory) | ||
| { | ||
| // require(req.chainid == block.chainid, "MinimalForwarder: invalid chainId"); | ||
| require(verify(req, signature), "MinimalForwarder: signature does not match request"); | ||
| _nonces[req.from] = req.nonce + 1; | ||
|
|
||
| (bool success, bytes memory returndata) = req.to.call{ gas: req.gas, value: req.value }( | ||
| abi.encodePacked(req.data, req.from) | ||
| ); | ||
|
|
||
| // Validate that the relayer has sent enough gas for the call. | ||
| // See https://ronan.eth.link/blog/ethereum-gas-dangers/ | ||
| if (gasleft() <= req.gas / 63) { | ||
| // We explicitly trigger invalid opcode to consume all gas and bubble-up the effects, since | ||
| // neither revert or assert consume all gas since Solidity 0.8.0 | ||
| // https://docs.soliditylang.org/en/v0.8.0/control-structures.html#panic-via-assert-and-error-via-require | ||
| assembly { | ||
| invalid() | ||
| } | ||
| } | ||
|
|
||
| return (success, returndata); | ||
| } |
Check failure
Code scanning / Slither
Functions that send Ether to arbitrary destinations
Comment on lines
+42
to
+66
| function execute(ForwardRequest calldata req, bytes calldata signature) | ||
| public | ||
| payable | ||
| returns (bool, bytes memory) | ||
| { | ||
| require(verify(req, signature), "MinimalForwarder: signature does not match request"); | ||
| _nonces[req.from] = req.nonce + 1; | ||
|
|
||
| // solhint-disable-next-line avoid-low-level-calls | ||
| (bool success, bytes memory result) = req.to.call{ gas: req.gas, value: req.value }( | ||
| abi.encodePacked(req.data, req.from) | ||
| ); | ||
|
|
||
| if (!success) { | ||
| // Next 5 lines from https://ethereum.stackexchange.com/a/83577 | ||
| if (result.length < 68) revert("Transaction reverted silently"); | ||
| assembly { | ||
| result := add(result, 0x04) | ||
| } | ||
| revert(abi.decode(result, (string))); | ||
| } | ||
| // Check gas: https://ronan.eth.link/blog/ethereum-gas-dangers/ | ||
| assert(gasleft() > req.gas / 63); | ||
| return (success, result); | ||
| } |
Check failure
Code scanning / Slither
Functions that send Ether to arbitrary destinations
Comment on lines
+42
to
+66
| function execute(ForwardRequest calldata req, bytes calldata signature) | ||
| public | ||
| payable | ||
| returns (bool, bytes memory) | ||
| { | ||
| require(verify(req, signature), "MinimalForwarder: signature does not match request"); | ||
| _nonces[req.from] = req.nonce + 1; | ||
|
|
||
| // solhint-disable-next-line avoid-low-level-calls | ||
| (bool success, bytes memory result) = req.to.call{ gas: req.gas, value: req.value }( | ||
| abi.encodePacked(req.data, req.from) | ||
| ); | ||
|
|
||
| if (!success) { | ||
| // Next 5 lines from https://ethereum.stackexchange.com/a/83577 | ||
| if (result.length < 68) revert("Transaction reverted silently"); | ||
| assembly { | ||
| result := add(result, 0x04) | ||
| } | ||
| revert(abi.decode(result, (string))); | ||
| } | ||
| // Check gas: https://ronan.eth.link/blog/ethereum-gas-dangers/ | ||
| assert(gasleft() > req.gas / 63); | ||
| return (success, result); | ||
| 8000 | } |
Check warning
Code scanning / Slither
Assembly usage
Comment on lines
+56
to
+81
| function execute(ForwardRequest calldata req, bytes calldata signature) | ||
| public | ||
| payable | ||
| returns (bool, bytes memory) | ||
| { | ||
| // require(req.chainid == block.chainid, "MinimalForwarder: invalid chainId"); | ||
| require(verify(req, signature), "MinimalForwarder: signature does not match request"); | ||
| _nonces[req.from] = req.nonce + 1; | ||
|
|
||
| (bool success, bytes memory returndata) = req.to.call{ gas: req.gas, value: req.value }( | ||
| abi.encodePacked(req.data, req.from) | ||
| ); | ||
|
|
||
| // Validate that the relayer has sent enough gas for the call. | ||
| // See https://ronan.eth.link/blog/ethereum-gas-dangers/ | ||
| if (gasleft() <= req.gas / 63) { | ||
| // We explicitly trigger invalid opcode to consume all gas and bubble-up the effects, since | ||
| // neither revert or assert consume all gas since Solidity 0.8.0 | ||
| // https://docs.soliditylang.org/en/v0.8.0/control-structures.html#panic-via-assert-and-error-via-require | ||
| assembly { | ||
| invalid() | ||
| } | ||
| } | ||
|
|
||
| return (success, returndata); | ||
| } |
Check warning
Code scanning / Slither
Assembly usage
Comment on lines
+42
to
+66
| function execute(ForwardRequest calldata req, bytes calldata signature) | ||
| public | ||
| payable | ||
| returns (bool, bytes memory) | ||
| { | ||
| require(verify(req, signature), "MinimalForwarder: signature does not match request"); | ||
| _nonces[req.from] = req.nonce + 1; | ||
|
|
||
| // solhint-disable-next-line avoid-low-level-calls | ||
| (bool success, bytes memory result) = req.to.call{ gas: req.gas, value: req.value }( | ||
| abi.encodePacked(req.data, req.from) | ||
| ); | ||
|
|
||
| if (!success) { | ||
| // Next 5 lines from https://ethereum.stackexchange.com/a/83577 | ||
| if (result.length < 68) revert("Transaction reverted silently"); | ||
| assembly { | ||
| result := add(result, 0x04) | ||
| } | ||
| revert(abi.decode(result, (string))); | ||
| } | ||
| // Check gas: https://ronan.eth.link/blog/ethereum-gas-dangers/ | ||
| assert(gasleft() > req.gas / 63); | ||
| return (success, result); | ||
| } |
Check warning
Code scanning / Slither
Low-level calls
Comment on lines
+56
to
+81
| function execute(ForwardRequest calldata req, bytes calldata signature) | ||
| public | ||
| payable | ||
| returns (bool, bytes memory) | ||
| { | ||
| // require(req.chainid == block.chainid, "MinimalForwarder: invalid chainId"); | ||
| require(verify(req, signature), "MinimalForwarder: signature does not match request"); | ||
| _nonces[req.from] = req.nonce + 1; | ||
|
|
||
| (bool success, bytes memory returndata) = req.to.call{ gas: req.gas, value: req.value }( | ||
| abi.encodePacked(req.data, req.from) | ||
| ); | ||
|
|
||
| // Validate that the relayer has sent enough gas for the call. | ||
| // See https://ronan.eth.link/blog/ethereum-gas-dangers/ | ||
| if (gasleft() <= req.gas / 63) { | ||
| // We explicitly trigger invalid opcode to consume all gas and bubble-up the effects, since | ||
| // neither revert or assert consume all gas since Solidity 0.8.0 | ||
| // https://docs.soliditylang.org/en/v0.8.0/control-structures.html#panic-via-assert-and-error-via-require | ||
| assembly { | ||
| invalid() | ||
| } | ||
| } | ||
|
|
||
| return (success, returndata); | ||
| } |
Check warning
Code scanning / Slither
Low-level calls
|
For chainless we should support https://github.com/ethereum/EIPs/blob/master/EIPS/eip-712.md#definition-of-domainseparator |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.