8000 feat: support for puppeteer 24 by yadue · Pull Request #555 · thomasdondorf/puppeteer-cluster · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: support for puppeteer 24 #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: support for puppeteer 24 #555

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,8 @@
"coveralls": "^3.1.1",
"express": "^4.18.3",
"jest": "^29.7.0",
"puppeteer": "^22.5.0",
"puppeteer-core": "^22.5.0",
"puppeteer": "^24.2.0",
"puppeteer-core": "^24.2.0",
"tree-kill": "^1.2.2",
"ts-jest": "^29.1.2",
"typescript": "^5.4.2"
Expand Down
8 changes: 4 additions & 4 deletions src/Cluster.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import Worker, { WorkResult } from './Worker';

import * as builtInConcurrency from './concurrency/builtInConcurrency';

import type { Page, PuppeteerNodeLaunchOptions } from 'puppeteer';
import type { Page, LaunchOptions } from 'puppeteer';
import Queue from './Queue';
import SystemMonitor from './SystemMonitor';
import { EventEmitter } from 'events';
Expand All @@ -19,8 +19,8 @@ interface ClusterOptions {
concurrency: number | ConcurrencyImplementationClassType;
maxConcurrency: number;
workerCreationDelay: number;
puppeteerOptions: PuppeteerNodeLaunchOptions;
perBrowserOptions: PuppeteerNodeLaunchOptions[] | undefined;
puppeteerOptions: LaunchOptions;
perBrowserOptions: LaunchOptions[] | undefined;
monitor: boolean;
timeout: number;
retryLimit: number;
Expand Down Expand Up @@ -76,7 +76,7 @@ export default class Cluster<JobData = any, ReturnData = any> extends EventEmitt
static CONCURRENCY_BROWSER = 3; // no cookie sharing and individual processes (uses contexts)

private options: ClusterOptions;
private perBrowserOptions: PuppeteerNodeLaunchOptions[] | null = null;
private perBrowserOptions: LaunchOptions[] | null = null;
private workers: Worker<JobData, ReturnData>[] = [];
private workersAvail: Worker<JobData, ReturnData>[] = [];
private workersBusy: Worker<JobData, ReturnData>[] = [];
Expand Down
Loading
0