Fix: Change block commenting to comply with PEP 8 #3563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
871bbb5 to
4e3e1cb
Compare
4e3e1cb to
2a4f564
Compare
Refactored the _selection_is_line_commented, _comment_selection, and _uncomment_selection functions to use str.format() for string formatting instead of string concatenation to improve readability.
|
Thanks for the PR and sorry for the late reply! Unfortunately it is hard to see what is the real change, because you have changed string formatting in several places. Or does it matter for getting the desired change? |
|
Functional commit is on d007c5a the other commits are for style/readability only |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to fix #3404: Ensure commenting behavior adheres to PEP 8 guidelines
This pull request addresses the previously non-compliant commenting behavior in our codebase. The commenting behavior have been updated to meet PEP 8 standards. Both space and tab indentation (single and multi-line selection) have been tested and work correctly.
Please review the changes and let me know if they do not conform to any internal code guidelines. I am happy to make further adjustments to comply with the standards.
Thank you!