Remove most uses of gap_to_julia #1771
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't worry about the version. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1771 +/- ##
===========================================
+ Coverage 6.44% 76.36% +69.92%
===========================================
Files 362 362
Lines 114242 114381 +139
===========================================
+ Hits 7362 87349 +79987
+ Misses 106880 27032 -79848
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some progress towards oscar-system/Oscar.jl#4625.
The remaining three calls are in the meataxe code, and are present in
Oscar.jl/experimental/GModule/src/GModule.jlas well. Those need probably the same changes.I am not quite sure if such a strict restrictions of GAP.jl versions is necessary, but I am pretty certain that 0.9.6 won't work any more with all of the changes regarding conversions last year. If there is a good reason to keep older versions in there, I can try to test a few combinations, but otherwise I won't spend the time.
cc @fingolfin