Followup after changes in OSCAR #1783
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1783 +/- ##
==========================================
- Coverage 76.40% 76.37% -0.04%
==========================================
Files 360 362 +2
Lines 114106 114439 +333
==========================================
+ Hits 87184 87403 +219
- Misses 26922 27036 +114
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to avoid breaking OSCAR, we had to add an extra function in Hecke, related to
short_vectors_affine(#1729). Now that we have removed redundant code in oscar-system/Oscar.jl#4583, we can remove this function.I also fixed some documentation, to have properly one doc-string for each of the two
short_vectors_affinefunctions since they behave slightly differently (coordinates of vectors).As I mentioned in oscar-system/Oscar.jl#4583 (comment), I needed to adapt the code of
enumerate_quadratic_triplesbecause_convert_typemight not work forZZMatrixin entry. The simple fix is to force conversion of the inputs intoQQMatrixif they are not already.