8000 Bump Nemo to 0.50, AA to 0.45, Polymake to 0.12 by lgoettgens · Pull Request #1871 · thofma/Hecke.jl · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Bump Nemo to 0.50, AA to 0.45, Polymake to 0.12 #1871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 16, 2025
Merged

Bump Nemo to 0.50, AA to 0.45, Polymake to 0.12 #1871

merged 7 commits into from
May 16, 2025

Conversation

lgoettgens
Copy link
Contributor
@lgoettgens lgoettgens commented May 16, 2025 •
edited
Loading

Contains and thus closes #1870.

8000
@lgoettgens lgoettgens force-pushed the lg/Nemo-AA-bump branch from 1d76657 to a11c37b Compare May 16, 2025 12:51
@lgoettgens
Copy link
Contributor Author

@thofma please feel free to help out here (aka push small fixes to failures in CI) if you have the time to do so. I will try to chime in every few hours to give CI some time to run tests

lgoettgens
lgoettgens commented May 16, 2025
View reviewed changes
@lgoettgens lgoettgens closed this May 16, 2025
@lgoettgens lgoettgens reopened this May 16, 2025
@lgoettgens lgoettgens changed the title Bump Nemo to 0.50, AA to 0.45 Bump Nemo to 0.50, AA to 0.45, Polymake to 0.12 May 16, 2025
lgoettgens
lgoettgens commented May 16, 2025
View reviewed changes
@lgoettgens lgoettgens marked this pull request as ready for review May 16, 2025 16:38
@codecov Codecov
Copy link
codecov bot commented May 16, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.53%. Comparing base (a3711cf) to head (61d6c17).
Report is 2 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1871      +/-   ##
==========================================
- Coverage   76.60%   76.53%   -0.08%     
==========================================
  Files         364      364              
  Lines      115434   115434              
==========================================
- Hits        88430    88349      -81     
- Misses      27004    27085      +81
Files with missing lines Coverage Δ
src/AlgAssAbsOrd/ResidueRingMultGrp.jl 87.91% <100.00%> (ø)
src/HeckeTypes.jl 85.36% <100.00%> (ø)

... and 30 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@thofma
Copy link
Owner
thofma commented May 16, 2025

looking good (the nightly breakage is expected)

@thofma thofma merged commit 0beab69 into thofma:master May 16, 2025
16 of 17 checks passed
@lgoettgens lgoettgens deleted the lg/Nemo-AA-bump branch May 16, 2025 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
release notes: not needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lgoettgens @thofma
0