Rename 'authorizationProvider' to 'authenticationProvider' #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This completes the rename started in c873afb (this parameter label was missed).
houndci-bot
reviewed
Aug 21, 2017
| @@ -170,7 +170,7 @@ final class RequestAuthorizerSpec: QuickSpec { | |||
| describe("clearToken") { | |||
| it("removes the token from token storage") { | |||
| let testTokenStorage = SimpleTokenStorage(token: "some-token") | |||
| let authorizer = RequestAuthorizer(authorizationProvider: TestAuthenticationProvider(), tokenStorage: testTokenStorage) | |||
| let authorizer = RequestAuthorizer(authenticationProvider: TestAuthenticationProvider(), tokenStorage: testTokenStorage) | |||
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 128 characters (line_length)
There was a problem hiding this comment.
Maybe I should disable the line length one. Signal-to-noise is low.
| where Provider.Token == Token | ||
| { | ||
| let keychainTokenStorage = KeychainTokenStorage<Token>(service: Provider.keychainServiceName, label: Provider.identifier) | ||
| self.init(authorizationProvider: authorizationProvider, tokenStorage: keychainTokenStorage, applicationDelegate: applicationDelegate, urlSession: urlSession) | ||
| self.init(authenticationProvider: authenticationProvider, tokenStorage: keychainTokenStorage, applicationDelegate: applicationDelegate, urlSession: urlSession) |
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 163 characters (line_length)
| @@ -282,11 +282,11 @@ public final class RequestAuthorizer<Token>: RequestAuthorizerProtocol { | |||
| } | |||
|
|
|||
| extension RequestAuthorizer where Token: KeychainDecodable & KeychainEncodable { | |||
| public convenience init<Provider: AuthenticationProvider>(authorizationProvider: Provider, applicationDelegate: @autoclosure @escaping () -> UIApplicationDelegate? = defaultApplicationDelegate, urlSession: URLSession = .shared) | |||
| public convenience init<Provider: AuthenticationProvider>(authenticationProvider: Provider, applicationDelegate: @autoclosure @escaping () -> UIApplicationDelegate? = defaultApplicationDelegate, urlSession: URLSession = .shared) | |||
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 230 characters (line_length)
| @@ -13,13 +13,13 @@ public final class RequestAuthorizer<Token>: RequestAuthorizerProtocol { | |||
| private let authenticationComplete: Channel<AuthenticationResult<Token>> | |||
| private let authenticationState: Actor<AuthenticationState<Token>> | |||
|
|
|||
| public init<Provider: AuthenticationProvider, Storage: TokenStorage>(authorizationProvider: Provider, tokenStorage: Storage, applicationDelegate: @autoclosure @escaping () -> UIApplicationDelegate? = defaultApplicationDelegate, urlSession: URLSession = .shared) | |||
| public init<Provider: AuthenticationProvider, Storage: TokenStorage>(authenticationProvider: Provider, tokenStorage: Storage, applicationDelegate: @autoclosure @escaping () -> UIApplicationDelegate? = defaultApplicationDelegate, urlSession: URLSession = .shared) | |||
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 264 characters (line_length)
|
|
||
| public extension RequestAuthorizer where Token: KeychainDecodable & KeychainEncodable { | ||
| @available(*, unavailable, renamed: "init(authenticationProvider:applicationDelegate:urlSession:)") | ||
| convenience init<Provider: AuthenticationProvider>(authorizationProvider: Provider, applicationDelegate: @autoclosure @escaping () -> UIApplicationDelegate? = nil, urlSession: URLSession = .shared) |
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 199 characters (line_length)
|
|
||
| public extension RequestAuthorizer { | ||
| @available(*, unavailable, renamed: "init(authenticationProvider:tokenStorage:applicationDelegate:urlSession:)") | ||
| convenience init<Provider: AuthenticationProvider, Storage: TokenStorage>(authorizationProvider: Provider, tokenStorage: Storage, applicationDelegate: @autoclosure @escaping () -> UIApplicationDelegate? = nil, urlSession: URLSession = .shared) |
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 245 characters (line_length)
| public extension RequestAuthorizer where Token: KeychainDecodable & KeychainEncodable { | ||
| @available(*, unavailable, renamed: "init(authenticationProvider:applicationDelegate:urlSession:)") | ||
| convenience init<Provider: AuthenticationProvider>(authorizationProvider: Provider, applicationDelegate: @autoclosure @escaping () -> UIApplicationDelegate? = nil, urlSession: URLSession = .shared) | ||
| where Provider.Token == Token |
There was a problem hiding this comment.
Opening Brace Spacing Violation: Opening braces should be preceded by a single space and on the same line as the declaration. (opening_brace)
| public extension RequestAuthorizer { | ||
| @available(*, unavailable, renamed: "init(authenticationProvider:tokenStorage:applicationDelegate:urlSession:)") | ||
| convenience init<Provider: AuthenticationProvider, Storage: TokenStorage>(authorizationProvider: Provider, tokenStorage: Storage, applicationDelegate: @autoclosure @escaping () -> UIApplicationDelegate? = nil, urlSession: URLSession = .shared) | ||
| where Provider.Token == Token, Storage.Token == Token |
There was a problem hiding this comment.
Opening Brace Spacing Violation: Opening braces should be preceded by a single space and on the same line as the declaration. (opening_brace)
sidraval
approved these changes
Aug 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This completes the rename started in c873afb (this parameter label was missed).