Cleanup Bundler ENV variable introduced in Bundler 2.4 #229

deivid-rodriguez · 2024-08-20T18:05:30Z

See rubygems/rubygems#6025.

This gets most specs passing with the latest version of Bundler.

Closes #218.

n-rodriguez · 2024-08-20T19:23:22Z

@deivid-rodriguez thank you! ❤️

n-rodriguez · 2024-08-21T15:42:15Z

ping @nickcharlton

n-rodriguez · 2024-08-27T10:18:42Z

ping @neilvcarvalho

tisba · 2024-08-30T07:45:39Z

I'm not sure I follow why the referenced Rubygems PR should fix #218. I get the same errors when running this changeset locally I got with #218.

n-rodriguez · 2024-08-30T08:49:52Z

I'm not sure I follow why the referenced Rubygems PR should fix #218. I get the same errors when running this changeset locally I got with #218.

@tisba The referenced PR is for history. Actually bundler has been patched to fix the issue (rubygems/rubygems#7925). The fix has been released with bundler 2.5.18. Now we need this patch to fix another issue (see: rubygems/rubygems#7925 (comment)).

n-rodriguez · 2024-08-30T08:51:38Z

I've made a PR based on this one (#230) that implements CI with GithubActions.

You can check the result here : https://github.com/thoughtbot/appraisal/actions/runs/10570162976/job/29284184720?pr=230

n-rodriguez · 2024-09-09T15:03:19Z

ping @nickcharlton

tisba · 2024-09-19T06:12:37Z

When I checkout this PR, using bundler 2.5.19, rubygems 3.5.19 on ruby 3.3.5 (arm64-darwin23), I get two broken tests when running rspec:

$ rspec
..Bundler can't satisfy your Gemfile's dependencies.
Install missing gems with `bundle install`.
.Bundler can't satisfy your Gemfile's dependencies.
Install missing gems with `bundle install`.
.Bundler can't satisfy your Gemfile's dependencies.
Install missing gems with `bundle install`.
........Bundler can't satisfy your Gemfile's dependencies.
Install missing gems with `bundle install`.
.................warning: re-init: ignored --initial-branch=master
.......F.F.........................................................................

Failures:

  1) Appraisal::AppraisalFile#customize_gemfiles when a block is given when the block returns a hash with :heading key sets the heading
     Failure/Error:
       def self.heading(gemfile)
         @@heading ||= nil
         customize(@@heading, gemfile)
       end

     ArgumentError:
       wrong number of arguments (given 0, expected 1)
     # ./lib/appraisal/customize.rb:8:in `heading'
     # ./spec/appraisal/appraisal_file_spec.rb:38:in `block (6 levels) in <top (required)>'
     # ./spec/appraisal/appraisal_file_spec.rb:38:in `block (5 levels) in <top (required)>'

  2) Appraisal::AppraisalFile#customize_gemfiles when a block is given when the block returns a hash with :heading and :single_quotes keys sets the heading and single_quotes
     Failure/Error:
       def self.heading(gemfile)
         @@heading ||= nil
         customize(@@heading, gemfile)
       end

     ArgumentError:
       wrong number of arguments (given 0, expected 1)
     # ./lib/appraisal/customize.rb:8:in `heading'
     # ./spec/appraisal/appraisal_file_spec.rb:63:in `block (5 levels) in <top (required)>'

Finished in 57.5 seconds (files took 0.21106 seconds to load)
112 examples, 2 failures

Failed examples:

rspec ./spec/appraisal/appraisal_file_spec.rb:37 # Appraisal::AppraisalFile#customize_gemfiles when a block is given when the block returns a hash with :heading key sets the heading
rspec ./spec/appraisal/appraisal_file_spec.rb:61 # Appraisal::AppraisalFile#customize_gemfiles when a block is given when the block returns a hash with :heading and :single_quotes keys sets the heading and single_quotes

Unfortunately I don't really have much time to dig in more - hope it helps anyway.

deivid-rodriguez · 2024-09-19T10:24:35Z

Did you get specs to pass previously and this is something that broke in Bundler 2.5.19 /RubyGems 3.5.19 or it's the first time you tried this PR?

Ideally we'd get this merged and a CI back on track to be able to troubleshoot these things more easily from now on.

n-rodriguez · 2024-09-19T12:12:44Z

@tisba this errors has nothing to do with bundler. The issue is that def self.heading(gemfile) signature has changed and the tests were not updated.

n-rodriguez · 2024-09-19T12:14:29Z

@nickcharlton I would really appreciate if you could merge this PR (and this one #230) to get appraisal gem back in green CI. Thank you!

n-rodriguez · 2024-09-19T12:15:40Z

@tisba I skip this broken tests in PR #230 : 47b185e

before the method signature was changed : https://github.com/thoughtbot/appraisal/blame/f5e31c48a1dda036a2c13663fad1b657a0953f5d/lib/appraisal/customize.rb
after the method signature change : https://github.com/thoughtbot/appraisal/blame/main/lib/appraisal/customize.rb

nickcharlton · 2024-09-23T15:37:44Z

Thanks for doing this!

@n-rodriguez, I appreciate the pings, thank you! (Even though I basically didn't do anything about it until now 😅)

See rubygems/rubygems#6025.

n-rodriguez · 2024-09-23T15:44:45Z

@nickcharlton awesome! thank you!

deivid-rodriguez mentioned this pull request Aug 20, 2024

Bundler does not support local git repositories with relative paths rubygems/rubygems#7925

Closed

n-rodriguez mentioned this pull request Aug 20, 2024

Housekeeping #230

Closed

n-rodriguez mentioned this pull request Aug 26, 2024

Running appraisal specs with Bundler >= 2.4.0 broken #218

Closed

Cleanup Bundler ENV variable introduced in Bundler 2.4

be67a08

See rubygems/rubygems#6025.

nickcharlton force-pushed the unset-bundler-2.4-new-env branch from 7087fbf to be67a08 Compare September 23, 2024 15:38

nickcharlton merged commit cc074a6 into thoughtbot:main Sep 23, 2024
1 check passed

deivid-rodriguez deleted the unset-bundler-2.4-new-env branch September 23, 2024 16:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cleanup Bundler ENV variable introduced in Bundler 2.4 #229

Cleanup Bundler ENV variable introduced in Bundler 2.4 #229

Cleanup Bundler ENV variable introduced in Bundler 2.4 #229

Cleanup Bundler ENV variable introduced in Bundler 2.4 #229

Conversation