8000 Update webextension-polyfill to work in the most recent Chrome version by rafaelsc · Pull Request #78 · threejs/three-devtools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Dec 12, 2022. It is now read-only.

Update webextension-polyfill to work in the most recent Chrome version #78

Open
wants to merge 6 commits into
base: master
Choose a base branch
8000
from
Open

Update webextension-polyfill to work in the most recent Chrome version #78

wants to merge 6 commits into from

Conversation

rafaelsc
Copy link
@rafaelsc rafaelsc commented Jun 24, 2022 •
edited
Loading
  • Update webextension-polyfill to work in the most recent Chrome version.
  • Use onDOMContentLoaded to load the Tool Script
  • Solves Chrome endless loading #74

The old webextension-polyfill is causing issies with Chrome, making you need to refresh many times the page to the extentions start watching the scene.

@mrdoob
Copy link
Member
mrdoob commented Jun 28, 2022

Do we even need this polyfill? 🤔

@mrdoob mrdoob requested a review from jsantell June 28, 2022 06:56
@rafaelsc
Copy link
Author
rafaelsc commented Jul 1, 2022

@mrdoob I don't know. I don't have too much experience with extensions. I tried to remove and look like the change would be bigger. And I only manage to make work upgrading the polyfill, changing the event to be onDOMContentLoaded.

@zadinvit
Copy link

This changes work fine. Thanks @rafaelsc. Please merge this to master.

@rafaelsc
Copy link
Author

Sorry @zadinvit. I don't have permission to complete this PR (merging to master)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jsantell jsantell Awaiting requested review from jsantell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rafaelsc @mrdoob @zadinvit
0