fix: prevent in-place operations in TimesNet model to avoid potential side effects #709

Karesis · 2025-04-09T01:05:55Z

Changes

This PR addresses potential side effects caused by in-place operations in the TimesNet model.

Replaced in-place operators (e.g., /=, +=) with their non-in-place counterparts (e.g., = x / y, = x + y)
Ensured all tensor operations create new objects instead of modifying existing ones
Maintained the original mathematical operations while improving code safety

In-place operators (/=, +=, etc.) modify tensors directly, which can lead to unexpected side effects
Using non-in-place operations creates new objects, making the code behavior more predictable
This change prevents potential issues in model training and inference

These modifications follow defensive programming practices by avoiding in-place operations, making the code more robust and easier to debug.

… side effects

wuhaixu2016 · 2025-05-17T09:14:33Z

Thanks for your contribution.

fix: prevent in-place operations in TimesNet model to avoid potential…

4c2fae5

… side effects

wuhaixu2016 merged commit 4e40c43 into thuml:main May 17, 2025