8000 Chore: migrate CommentView to internal models by hjiangsu · Pull Request #1858 · thunder-app/thunder · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Chore: migrate CommentView to internal models #1858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 12, 2025
Merged

Chore: migrate CommentView to internal models #1858

merged 3 commits into from
Jun 12, 2025

Conversation

hjiangsu
Copy link
Member
@hjiangsu hjiangsu commented Jun 1, 2025 •
edited
Loading

Pull Request Description

This is in draft, since this PR will likely be merged after v0.7.0 is generally available (to prevent any potential issues from popping up).

Update: I'll be merging this into a separate branch chore/migrate-lemmy-models so that work can continue. Once v0.7.0 is released, I'll create another PR to merge the parent branch into develop.

This PR migrates our usage of CommentView to use internal models ThunderComment.

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

Checklist

  • If a new package was added, did you ensure it uses an appropriate license and is actively maintained?
  • Did you use localized strings (and added appropriate descriptions) where applicable?
  • Did you add semanticLabels where applicable for accessibility?

@hjiangsu hjiangsu force-pushed the feat/improve-user-community-header branch from 5dd1a4f to 594e570 Compare June 1, 2025 20:54
Base automatically changed from feat/improve-user-community-header to develop June 4, 2025 00:04
@hjiangsu hjiangsu force-pushed the chore/migrate-comment-view branch from 457842a to 360a9e2 Compare June 4, 2025 18:21
@hjiangsu hjiangsu changed the base branch from develop to chore/migrate-lemmy-models June 12, 2025 21:26
@hjiangsu hjiangsu marked this pull request as ready for review June 12, 2025 21:27
@hjiangsu hjiangsu merged commit 78cc807 into chore/migrate-lemmy-models Jun 12, 2025
1 check passed
@hjiangsu hjiangsu deleted the chore/migrate-comment-view branch June 12, 2025 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hjiangsu
0