8000 Improve notification user handling by micahmo · Pull Request #1865 · thunder-app/thunder · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Improve notification user handling #1865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 4, 2025
Merged

Improve notification user handling #1865

merged 1 commit into from
Jun 4, 2025

Conversation

micahmo
Copy link
Member
@micahmo micahmo commented Jun 4, 2025

Pull Request Description

This PR makes a slight tweak to how notifications across multiple accounts are handled, specifically the use case of opening a notification directed at a user which is not the currently selected user in Thunder.

The previous behavior is:

  • Temporarily switch the context of the app to the new user
  • Perform any actions while looking at the notification as the new user
  • Restore the previous context when navigating out of the notifications page

This workflow has the potential for confusion regarding which user you are when you look at the notification, as well as when you navigate back (it changes without any indication), and it has potential for bugs as well.

I propose a new workflow, which is to explicitly change the selected user to the one that received the notification, and tell the user we are making this change via a snackbar. Then do not automatically switch back to another user. That can be done manually if desired.

This change is inspired by how some popular social media apps work, and I think it makes the whole interaction much more clear and straightforward.

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

qemu-system-x86_64_hn6OGxXZLC.mp4

Checklist

  • If a new package was added, did you ensure it uses an appropriate license and is actively maintained?
  • Did you use localized strings (and added appropriate descriptions) where applicable?
  • Did you add semanticLabels where applicable for accessibility?

@micahmo micahmo requested a review from hjiangsu June 4, 2025 16:06
hjiangsu
hjiangsu approved these changes Jun 4, 2025
View reviewed changes
Copy link
Member
@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I agree with the new flow 😊

@hjiangsu hjiangsu merged commit a4e54d8 into thunder-app:develop Jun 4, 2025
1 check passed
@micahmo micahmo deleted the feature/improve-notification-user-handling branch June 4, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjiangsu hjiangsu hjiangsu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@micahmo @hjiangsu
0