8000 Dark theme (& Material You theming) for widget by vayun-mathur · Pull Request #8719 · thunderbird/thunderbird-android · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Dark theme (& Material You theming) for widget #8719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 19, 2025
Merged

Dark theme (& Material You theming) for widget #8719

merged 1 commit into from
Mar 19, 2025

Conversation

vayun-mathur
Copy link
Contributor

Completes #3728

Rebuilt the message list widget using Jetpack Glance and incorporated dark mode and material you theming for the color scheme

This is what the widget looks like now when dark mode is enabled:

Screenshot_20250106-153429

@wmontwe wmontwe self-assigned this Jan 6, 2025
@vayun-mathur
Copy link
Contributor Author

most recent commit should fix the style build issues @wmontwe

wmontwe
wmontwe requested changes Feb 19, 2025
View reviewed changes
Copy link
Member
@wmontwe wmontwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I apologize for the delay in getting back to you. This change is indeed very positive and represents a good starting point, though it still requires additional work. Instead of replacing the existing widget, I suggest that the changes be implemented in a separate module. Maybe guarded with a feature flag or integration in debug and daily only while beta and release disable that widget.

This approach will allow us to enhance the new version while keeping the original widget available.

Ideas/Improvements:

  • The Glance Theme should align with our app theme and be compatible with K-9 and TfA. A new common module for widgets could serve this purpose.
  • This common module could also house UI elements that can be reused in future widgets.
  • The widget currently displays the unified folder but does not yet use account colors to differentiate messages.
  • Naming should adhere to the existing scheme.
  • It's important to test how the widget performs across both applications.

Please let me know which aspects you would like to address personally. Some of these improvements can be broken down into follow-up tasks to complete the widget development.

@vayun-mathur
Copy link
Contributor Author

Ok I think that makes sense. I'll start by moving this moving this into its own module and restoring the old widget

@kewisch
Copy link
Member
kewisch commented Mar 6, 2025

@vayun-mathur have you had a chance to get back to this? We'd love to see this merged and much appreciate the effort you are putting into it and would love to enable the new widget on beta once it's ready.

@wmontwe wmontwe removed the request for review from cketti March 6, 2025 17:10
@vayun-mathur vayun-mathur requested a review from kewisch as a code owner March 6, 2025 19:27
@vayun-mathur
Copy link
Contributor Author
vayun-mathur commented Mar 6, 2025 •
edited
Loading

old widget has been added back and new widget has been moved into own module and naming has been made more consistent
I next plan to set the theme of the widget to the material colors if monochrome icons are enabled, and to the app theme otherwise

@kewisch kewisch requested a review from wmontwe March 10, 2025 15:42
@kewisch kewisch mentioned this pull request Mar 12, 2025
Open
3 tasks
@wmontwe wmontwe force-pushed the list-widget-themes branch from 64fa0ca to 7659f69 Compare March 19, 2025 11:20
wmontwe
wmontwe approved these changes Mar 19, 2025
View reviewed changes
Copy link
Member
@wmontwe wmontwe left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8000 @vayun-mathur Hi, sorry for taking so long, I went over the widget and fixed a couple of issues, joined all the changes into one commit and enabled the widget for K-9 debug and TfA debug and daily. I also added a preview to better review the widget UI.

I think it needs further work, but is now in a state that is a good foundation so we could merge this and do remaining work in follow-up pull-requests.

Open:

  • UI needs a design review
  • There are some glitches updating the widget, sometimes it just shows the loading screen.

@wmontwe wmontwe merged commit da6e2fe into thunderbird:main Mar 19, 2025
3 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Thanks for your contribution! Your pull request has been merged and will be part of Thunderbird 11. We appreciate the time and effort you put into improving Thunderbird. If you haven’t already, you’re welcome to join our Matrix chat for contributors. It’s where we discuss development and help each other out. https://matrix.to/#/#tb-android-dev:mozilla.org
Hope to see you there! 🚀📱🐦

@github-actions github-actions bot added this to the Thunderbird 11 milestone Mar 19, 2025
@kewisch kewisch mentioned this pull request May 20, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wmontwe wmontwe wmontwe approved these changes

@kewisch kewisch Awaiting requested review from kewisch kewisch is a code owner

Assignees

@wmontwe wmontwe

Labels
None yet
Projects
Thunderbird for Android - Sprints
Archived in project
Milestone
Thunderbird 11
Development

Successfully merging this pull request may close these issues.
3 participants
@vayun-mathur @kewisch @wmontwe
0