Force WKB parsing to allocate points on ARMv7 #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The WKB struct present in GeoBIN files isn't always memory aligned which doesn't work on ARMv7 cpus and leads to bus errors. This fix forces the points to be read with the read_posn function instead. Tested on x86_64, ARMv7, and aarch64.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please do not open a pull request without first filing an issue and/or discussing the feature directly with me.
Please ensure you adhere to every item in this list
Describe your changes
The WKB struct present in GeoBIN files isn't always memory aligned which doesn't work on ARMv7 cpus and leads to bus errors. This fix forces the points to be read with the read_posn function instead.
Tested on x86_64, ARMv7, and aarch64.
Issue number and link
See issue #12