8000 Feature Request : Custom API port · Issue #28 · tiehfood/thrifty · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Feature Request : Custom API port #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
t4nki opened this issue Feb 4, 2025 · 8 comments
Closed

Feature Request : Custom API port #28

t4nki opened this issue Feb 4, 2025 · 8 comments

Comments

@t4nki
Copy link
t4nki commented Feb 4, 2025

Hi

I believe this project is the simplest and most beautiful finace tracker I could find.
But, I have a hard time including it in my workflow.

I run my containers with podman, and group them in pods.
Pods allow you to host several containers with the same IP address.

The fact that ui container and api container run with the same port prevent them to being hosted in the same pod, and it has been buging me.

I'm no developper, but, as far as I understand, it seems golang could allow you to serve all endpoints in one container, eliminating the need for two containers serving one application.

I f this is not feasible, could it be possible setting the API listening port through environment variable.
I understand there is this new environment variable available since v1.5.0 but it still not fits in my workflow.

I hope I'm not being rude or pushy, I'd love to discuss this if necessary.

Regards
tiehfood added a commit that referenced this issue Feb 4, 2025
@tiehfood
feat: Custom API port (#28)
e1b5092
tiehfood added a commit that referenced this issue Feb 4, 2025
@tiehfood
Merge pull request #29 from tiehfood/feat-allow-setting-api-port
70ed233 
feat: Custom API port (#28)
@tiehfood
Copy link
Owner
tiehfood commented Feb 4, 2025

Hi @t4nki ,

thanks for your feature request. I can definitely get your point.
With version 1.6.0 I added an option to configure the listening port of the API with an environment variable PORT=desired_port.
Please try it out and let me know if it fixes your problem 😊

@t4nki
Copy link
Author
t4nki commented Feb 4, 2025
8000

That's great news !

I'm trying my workflow with this new option as I write, will keep you posted about the results

I have a lot of suggestions for your app, I will open tickets for each of those

@tiehfood
Copy link
Owner
tiehfood commented Feb 4, 2025 •
edited
Loading

😄 I will not guarantee you, that I consider every request, as I will keep the app simple.
But please fell free to open feature requests for your ideas :)

@t4nki
Copy link
Author
t4nki commented Feb 4, 2025

don't worry those will be small suggestions, to match what you want your app to be ;)

in the mean time it seems I can't wrap my head around my config
I can call the api from the ui container (localhost:8081/swagger/index.html) and I have an answer from swagger, but I have errors when I try to call it from my web browser
Thrifty runs on another machine, and the errors in the web console show this :

Image

money.rafale.lan is obviously the host the application runs on
it feels weird to see localhost:8081 in the logs, I guess it should be money.rafale.lan, meaning there might be a config error in /docker.entrypoint.d/01-sub.sh

I know jacksh!t about nginx config so I won't be of any help on this matter, might be something to explore though

Keep up the good work !

@tiehfood
Copy link
Owner
tiehfood commented Feb 5, 2025

I have to make the host of the backend also configurable. Currently it's always localhost. Without a reverse proxy this will fail, if you try to access it from a domain name or via IP.

I will post a fix later this day :)

tiehfood pushed a commit that referenced this issue Feb 5, 2025
feat: Custom API protocol and hostname (#28)
e4f4c19
@t4nki
Copy link
Author
t4nki commented Feb 5, 2025

just saw the update, i'll test it right away and keep you posted

@tiehfood
Copy link
Owner
tiehfood commented Feb 5, 2025

Yeah :) wait for the images (they take around 10min after new release). New parameters are LOACL_API_HOSTNAME and LOACL_API_PROTOCOL

@t4nki
Copy link
Author
t4nki commented Feb 5, 2025

I feel like I'm doing something wrong and that I might have to start all over again.
I'm closing this issue, because I made it work with your original docker-compose, I'm at fault here, it must be somewhere in my traefik config

@t4nki t4nki closed this as completed Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tiehfood @t4nki
0