8000 scheduler: evict hot leader first by rleungx · Pull Request #9275 · tikv/pd · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

scheduler: evict hot leader first #9275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

scheduler: evict hot leader first #9275

wants to merge 2 commits into from

Conversation

rleungx
Copy link
Member
@rleungx rleungx commented Apr 28, 2025 •
edited
Loading

What problem does this PR solve?

Issue Number: Close #8949

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

@rleungx
evict hot leader first
346fea0 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@ti-chi-bot ti-chi-bot
Copy link
Contributor
ti-chi-bot bot commented Apr 28, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. labels Apr 28, 2025
@ti-chi-bot ti-chi-bot
Copy link
Contributor
ti-chi-bot bot commented Apr 28, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from rleungx, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Apr 28, 2025
@codecov Codecov
Copy link
codecov bot commented Apr 28, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 86.66667% with 16 lines in your changes missing coverage. Please review.

Project coverage is 76.05%. Comparing base (873ea1e) to head (44f6a90).
Report is 3 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #9275      +/-   ##
==========================================
- Coverage   76.05%   76.05%   -0.01%     
==========================================
  Files         470      472       +2     
  Lines       73051    73132      +81     
==========================================
+ Hits        55562    55617      +55     
- Misses      14045    14066      +21     
- Partials     3444     3449       +5
Flag Coverage Δ
unittests 76.05% <86.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Tema
Copy link
Contributor
Tema commented Apr 28, 2025

@rleungx could you please share more background about this change?

@rleungx
record pending regions
44f6a90 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 29, 2025
@mittalrishabh
Copy link
Contributor

@rleungx we also have few ideas on how to handle hot regions especially in stale reads/follower reads environment. We should collaborate on this feature.

@rleungx
Copy link
Member Author
rleungx commented Apr 29, 2025

@Tema @mittalrishabh We are going to resolve #8949. This PR is just a draft now and is used for internal testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dco-signoff: yes Indicates the PR's author has signed the dco. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider evict leader according to the region's flow
3 participants
@rleungx @Tema @mittalrishabh
0