8000 hot_region: assign `historyLoads` to `LoadPred.Current` by okJiang · Pull Request #9271 · tikv/pd · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

hot_region: assign historyLoads to LoadPred.Current #9271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 27, 2025
Merged

hot_region: assign historyLoads to LoadPred.Current #9271

merged 3 commits into from
Apr 27, 2025

Conversation

okJiang
Copy link
Member
@okJiang okJiang commented Apr 27, 2025

What problem does this PR solve?

Issue Number: Close #9270

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

None.

@okJiang
fix
f95c2b1 
Signed-off-by: okJiang <819421878@qq.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/needs-triage-completed labels Apr 27, 2025
lhy1024
lhy1024 approved these changes Apr 27, 2025
View reviewed changes
pkg/statistics/store_hot_peers_infos.go
}
for j, historyLoad := range historyLoads {
for j, historyLoad := range loads {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to pick it to 8.5.2?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure about it.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Apr 27, 2025
@codecov Codecov
Copy link
codecov bot commented Apr 27, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.02%. Comparing base (873ea1e) to head (d238f67).
Report is 3 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #9271      +/-   ##
==========================================
- Coverage   76.05%   76.02%   -0.04%     
==========================================
  Files         470      470              
  Lines       73051    73053       +2     
==========================================
- Hits        55562    55535      -27     
- Misses      14045    14070      +25     
- Partials     3444     3448       +4
Flag Coverage Δ
unittests 76.02% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

okJiang added 2 commits April 27, 2025 16:42
@okJiang
add ut
ddf9509 
Signed-off-by: okJiang <819421878@qq.com>
@okJiang
fix static
d238f67 
Signed-off-by: okJiang <819421878@qq.com>
@ti-chi-bot ti-chi-bot
Copy link
Contributor
ti-chi-bot bot commented Apr 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JmPotato, lhy1024

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 27, 2025
@ti-chi-bot ti-chi-bot
Copy link
Contributor
ti-chi-bot bot commented Apr 27, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-04-27 07:58:10.575030468 +0000 UTC m=+774434.386820834: ☑️ agreed by lhy1024.
  • 2025-04-27 09:17:58.075359073 +0000 UTC m=+779221.887149451: ☑️ agreed by JmPotato.

@ti-chi-bot ti-chi-bot bot merged commit 2ce4446 into tikv:master Apr 27, 2025
25 checks passed
@okJiang okJiang deleted the fix-9270 branch April 28, 2025 05:52
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Apr 28, 2025
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 28, 2025
Open
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #9274.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JmPotato JmPotato JmPotato approved these changes

@lhy1024 lhy1024 lhy1024 approved these changes

Assignees
No one assigned
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HistoryLoads check are always skipped during hot_region_scheduler
4 participants
@okJiang @ti-chi-bot @JmPotato @lhy1024
0