8000 resource_group: replace LoadResourceGroups with GetResourceGroupsMeta… by disksing · Pull Request #9273 · tikv/pd · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

resource_group: replace LoadResourceGroups with GetResourceGroupsMeta… #9273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

resource_group: replace LoadResourceGroups with GetResourceGroupsMeta… #9273

wants to merge 5 commits into from
+52 −37

Conversation

disksing
Copy link
Contributor

…Revision

What problem does this PR solve?

Issue Number: Close #9272

What is changed and how does it work?

  • change the method to GetResourceGroupsMetaRevision which only returns meta revision.
  • add CountOnly option to allow only return kv count

Check List

Tests

  • Unit test

Related changes
merge after pingcap/kvproto#1309

Release note

None.

@disksing
resource_group: replace LoadResourceGroups with GetResourceGroupsMeta…
b1dc929 
…Revision

Signed-off-by: disksing <i@disksing.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 28, 2025
@disksing
tidy
dd69bbc 
Signed-off-by: disksing <i@disksing.com>
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 28, 2025
disksing added 3 commits April 28, 2025 12:34
@disksing
tidy
e1c7876 
Signed-off-by: disksing <i@disksing.com>
@disksing
tidy
3ff3f04 
Signed-off-by: disksing <i@disksing.com>
@disksing
fix test
11924d5 
Signed-off-by: disksing <i@disksing.com>
@codecov Codecov
Copy link
codecov bot commented Apr 28, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 65.38462% with 9 lines in your changes missing coverage. Please review.

Project coverage is 76.09%. Comparing base (873ea1e) to head (11924d5).
Report is 20 commits behind head on master.

❌ Your patch check has failed because the patch coverage (65.38%) is below the target coverage (74.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #9273      +/-   ##
==========================================
+ Coverage   76.05%   76.09%   +0.03%     
==========================================
  Files         470      472       +2     
  Lines       73051    73061      +10     
==========================================
+ Hits        55562    55597      +35     
+ Misses      14045    14027      -18     
+ Partials     3444     3437       -7
Flag Coverage Δ
unittests 76.09% <65.38%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ti-chi-bot ti-chi-bot
Copy link
Contributor
ti-chi-bot bot commented Apr 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nolouch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Apr 28, 2025
@ti-chi-bot ti-chi-bot
Copy link
Contributor
ti-chi-bot bot commented Apr 28, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-04-28 07:11:22.073969861 +0000 UTC m=+858025.885760242: ☑️ agreed by nolouch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nolouch nolouch nolouch approved these changes

Assignees
No one assigned
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. needs-1-more-lgtm Indicates a PR needs 1 more LGTM. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optimize LoadResourceGroups
2 participants
@disksing @nolouch
0