8000 core: Refactor checkstore and progress manager by okJiang · Pull Request #9333 · tikv/pd · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

core: Refactor checkstore and progress manager #9333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 49 commits into from
Jun 26, 2025
Merged

core: Refactor checkstore and progress manager #9333

merged 49 commits into from
Jun 26, 2025

Conversation

okJiang
Copy link
Member
@okJiang okJiang commented May 20, 2025 •
edited
Loading

What problem does this PR solve?

Issue Number: Close #8165

What is changed and how does it work?

  • Converge the progress calculation logic into the progress manager and progress indicator
  • Each time new data is added, the indicator will automatically calculate the progress
  • Progress related metrics will be updated in the progress manager
  • Refactoring checkStore using switch
  • Added GC logic in progress manager

Check List

Tests

  • Unit test
  • Integration test
  • Manual test

The speed change is smooth
image

After the online and offline are completed, the progress is 100
image

Release note

None.

okJiang added 8 commits May 19, 2025 15:52
@okJiang
save work
a98e593 
Signed-off-by: okJiang <819421878@qq.com>
@okJiang
add ut and complete progress
8f34a21 
Signed-off-by: okJiang <819421878@qq.com>
@okJiang
fix
f5c7dcc 
Signed-off-by: okJiang <819421878@qq.com>
@okJiang
add gc
cb695ba 
Signed-off-by: okJiang <819421878@qq.com>
@okJiang
fix ci
a536efa 
Signed-off-by: okJiang <819421878@qq.com>
@okJiang
fix ci
2770b50 
Signed-off-by: okJiang <819421878@qq.com>
@okJiang
fix ci
4f06e6d 
Signed-off-by: okJiang <819421878@qq.com>
@okJiang
fix ci
103ffb2 
Signed-off-by: okJiang <819421878@qq.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 20, 2025
@okJiang okJiang marked this pull request as draft May 20, 2025 09:53
@ti-chi-bot ti-chi-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 20, 2025
okJiang added 2 commits May 21, 2025 17:25
@okJiang
revert PatrolRegionsDuration
e3a764d 
Signed-off-by: okJiang <819421878@qq.com>
@okJiang
add ut TestDynamicPatrolRegionsDuration
92d8310 
Signed-off-by: okJiang <819421878@qq.com>
@okJiang okJiang marked this pull request as ready for review May 21, 2025 10:55
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 21, 2025
okJiang added 4 commits May 22, 2025 15:36
@okJiang
fix static
d429f85 
Signed-off-by: okJiang <819421878@qq.com>
@okJiang
add comment
e17353e 
Signed-off-by: okJiang <819421878@qq.com>
@okJiang
fix ut
0ad2a48 
Signed-off-by: okJiang <819421878@qq.com>
@okJiang
fix deadlock
b775b23 
Signed-off-by: okJiang <819421878@qq.com>
@okJiang
Copy link
Member Author
okJiang commented May 22, 2025

/retest

1 similar comment
@okJiang
Copy link
Member Author
okJiang commented May 22, 2025

/retest

okJiang added 3 commits May 23, 2025 11:03
@okJiang
save work
0fcc1da 
Signed-off-by: okJiang <819421878@qq.com>
@okJiang
fix ut
3566cfc 
Signed-off-by: okJiang <819421878@qq.com>
@okJiang
fix static
f7a1c34 
Signed-off-by: okJiang <819421878@qq.com>
@okJiang
Copy link
Member Author
okJiang commented May 26, 2025

/retest

2 similar comments
@okJiang
Copy link
Member Author
okJiang commented May 26, 2025

/retest

@okJiang
Copy link
Member Author
okJiang commented May 26, 2025

/retest

@okJiang
Copy link
Member Author
okJiang commented Jun 17, 2025

/retest

1 similar comment
@okJiang
Copy link
Member Author
okJiang commented Jun 18, 2025

/retest

@okJiang
Copy link
Member Author
okJiang commented Jun 20, 2025

/retest

8000
@okJiang
add a check
0412915 
Signed-off-by: okJiang <819421878@qq.com>
@ti-chi-bot ti-chi-bot bot added the lgtm label Jun 23, 2025
@ti-chi-bot ti-chi-bot
Copy link
Contributor
ti-chi-bot bot commented Jun 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JmPotato, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 23, 2025
@ti-chi-bot ti-chi-bot
Copy link
Contributor
ti-chi-bot bot commented Jun 23, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-06-05 06:41:29.908943933 +0000 UTC m=+510376.111289198: ☑️ agreed by JmPotato.
  • 2025-06-23 06:41:50.146753776 +0000 UTC m=+685962.869932781: ☑️ agreed by rleungx.

@okJiang
Copy link
Member Author
okJiang commented Jun 25, 2025

/retest

@ti-chi-bot ti-chi-bot bot merged commit ccec177 into tikv:master Jun 26, 2025
26 checks passed
@rleungx rleungx mentioned this pull request Jun 30, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JmPotato JmPotato JmPotato approved these changes

@rleungx rleungx rleungx approved these changes

Assignees
No one assigned
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The last moments of offline store and online store progress are not displayed correctly
3 participants
@okJiang @JmPotato @rleungx
0