core: Refactor checkstore and progress manager #9333
Conversation
Signed-off-by: okJiang <819421878@qq.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: okJiang <819421878@qq.com>
Signed-off-by: okJiang <819421878@qq.com>
Signed-off-by: okJiang <819421878@qq.com>
Signed-off-by: okJiang <819421878@qq.com>
Signed-off-by: okJiang <819421878@qq.com>
Signed-off-by: okJiang <819421878@qq.com>
|
/retest |
1 similar comment
|
/retest |
|
/retest |
1 similar comment
|
/retest |
|
/retest |
1 similar comment
|
/retest |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9333 +/- ##
==========================================
+ Coverage 75.98% 76.09% +0.10%
==========================================
Files 473 479 +6
Lines 73625 74308 +683
==========================================
+ Hits 55945 56544 +599
- Misses 14181 14247 +66
- Partials 3499 3517 +18
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Signed-off-by: okJiang <819421878@qq.com>
pkg/progress/indicator.go
Outdated
| if dur < minSpeedCalculationWindow { | ||
| dur = minSpeedCalculationWindow | ||
| } else if dur > maxSpeedCalculationWindow { | ||
| dur = maxSpeedCalculationWindow | ||
| } |
There was a problem hiding this comment.
Do we need to put two warn logs here as well?
pkg/progress/progress.go
Outdated
| } | ||
| } | ||
| }) | ||
| if p.completeAt.Before(time.Now().Add(-exactExpiredTime)) { |
There was a problem hiding this comment.
Perhaps call time.Now() outside the loop.
Signed-off-by: okJiang <819421878@q 6D40 q.com>
|
/retest |
What problem does this PR solve?
Issue Number: Close #8165
What is changed and how does it work?
Check List
Tests
The speed change is smooth
After the online and offline are completed, the progress is 100
Release note