8000 AY/YM Timer FX bug fixes and improvements by host12prog · Pull Request #2547 · tildearrow/furnace · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

AY/YM Timer FX bug fixes and improvements #2547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 30 commits into
base: master
Choose a base branch
from
Open

AY/YM Timer FX bug fixes and improvements #2547

wants to merge 30 commits into from

Conversation

host12prog
Copy link
Contributor
@host12prog host12prog commented Jun 2, 2025 •
edited
Loading

PLEASE SQUASH THE COMMITS! THERE ARE SOME UNRELATED GIT BLUNDERS IN THE COMMIT HISTORY!

  • renamed TFX Offset to Timer Offset
  • separated SyncBuzzer from channel mute state (necessary when another channel without envelope controls the SyncBuzzer of the envelope that's enabled on another channel)
  • fixed a timer effect bug

    if in the timer FX macro the user enables and then disables PWM while there is no volume macro there is now a random chance that the resulting output is silent or has volume set incorrectly

  • added labels to the timer effects when the macro is hovered
  • fixed a bug where the PWM timer output would crackle upon a volume change
  • fixed Timer Offset (formerly TFX Offset) macro's broken scroll and zoom
  • made timer effect 3 inaccessible until an use can be found for it (currently debating on what effect should be there). for the few songs that use it (against best advice), they will play normally (because it does nothing currently), but the end-user will not be able to input or use effect 3.
  • cleaned up the code a bit

tildearrow
tildearrow requested changes Jun 2, 2025
View reviewed changes
Copy link
Owner
@tildearrow tildearrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The warning must stay as TFX requires direct stream mode to be enabled.

@host12prog host12prog requested a review from tildearrow June 3, 2025 04:17
@freq-mod
Copy link
Collaborator
freq-mod commented Jun 3, 2025 
          ImGui::Text(_("warning: timer effects are not supported by VGM export!"));

They are - with direct stream mode

host12prog and others added 3 commits June 3, 2025 17:43
@host12prog
update warning message
fbdbb0f
@host12prog
add labels to the timer effects
cb829b3 
ugh. git + visual studio is a god damn temperamental combo
@host12prog
fix timer crackling
300ea13
@host12prog host12prog changed the title Separate SyncBuzzer from channel mute state and QOL AY/YM Timer FX bug fixes and improvements Jun 14, 2025
@freq-mod
Copy link
Collaborator

I would like to suggest either:

host12prog and others added 13 commits June 15, 2025 19:57
@host12prog
make timer effect 3 inaccessible until we can find a use for it
216eed9
@host12prog
oops, wrong register
87c1932
@host12prog
gah!
30d23ad
@host12prog
so it turns out it was the right register after all
9b98868
@host12prog
Merge branch 'tildearrow:master' into master
184bc0f
@tildearrow
OPL3: fix channel 7 hard reset
4af0345 
issue tildearrow#2582
@tildearrow
do not allow user to play notes during export
f02e38d 
issue tildearrow#2579
@tildearrow
get out of freelance mode when exporting audio
96624e8 
issue tildearrow#2579
@tildearrow
OPLL: fix pitch calculation
c3886dd 
possibly issue tildearrow#2538
@tildearrow
OPL4: fix PCM chan osc on ymfm??????
c08d42b 
issue tildearrow#2566
PCM only has two outputs
@tildearrow
OPLL: fix op 2 TL macro in preset patch
8d8aecc
@tildearrow
OPL4: fix PCM chan osc on ymfm
d7c5fce 
for real
issue tildearrow#2566
@tildearrow
GUI: improve edit advance behavior
42a2e2c 
now it goes to next pattern
issue tildearrow#2444
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tildearrow tildearrow Awaiting requested review from tildearrow

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@host12prog @freq-mod @tildearrow
0