Updated documentation for using $EXPECTED_REF on Windows #1175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
$EXPECTED_REF does not work on Windows, support was added via a different command in this PR tilt-dev/tilt-extensions#401
|
Thanks for pointing out this issue! However, I don't think the suggested fix is correct -- you'd typically use command_bat on windows machines, as nicksieger pointed out in the pr you referenced. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$EXPECTED_REF does not work on Windows, support was added with "%EXPECTED_REF%" in this PR
tilt-dev/tilt-extensions#401
Documentation was never updated, meaning I had to Google an error to find out about this.