8000 Support restarting multi process programs by allowing regex in process name by codeofpi · Pull Request #3 · timakro/superfsmon · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Support restarting multi process programs by allowing regex in process name #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support restarting multi process programs by allowing regex in process name #3

wants to merge 1 commit into from

Conversation

codeofpi
Copy link
@codeofpi codeofpi commented Apr 18, 2022 •
edited
Loading

With the current way of finding processes that needs to be restarted on code change, services with multiprocessing enabled are not restarted as the child processes in that case will have variable program names.

This pull request allows program and group argument to support regex input also.

for eg.

[program:abcd]
numprocs=4
numprocs_start=01
process_name=%(program_name)s_%(process_num)02d

@timakro
Copy link
Owner
timakro commented Apr 18, 2022

Thanks for your contribution! Here's what needs to be done before I can merge this:

  • The regular expression should already be re.compiled at the start and errors should be handled like this.
  • Instead of combining everything into a single regular expression keep a list of compiled regular expressions and use any(compiled_regex.match(program) for compiled_regex in program_regexes). By using match intead of search you don't have to wrap the regex in ^$.
  • Document that regular expressions are expected instead of plain strings in --help and update the README accordingly.

This is a breaking change in the rare case that existing PROG/GROUP params contain special regex characters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codeofpi @timakro @signalx-ai-temp
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
0