8000 Allow the Timber\PostPreview::read_more to accept a boolean value by gerardo-rodriguez · Pull Request #2578 · timber/timber · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Allow the Timber\PostPreview::read_more to accept a boolean value #2578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 24, 2024
Merged

Allow the Timber\PostPreview::read_more to accept a boolean value #2578

merged 1 commit into from
Feb 24, 2024

Conversation

gerardo-rodriguez
Copy link

Issue

The Timber\PostPreview::read_more docs say:

Set this to false to not add a "Read More" link.

But Timber\PostPreview::read_more doesn't actually accept a boolean value, it only accepts a string value type. 😬

Screen Shot 2022-04-29 at 11 37 53 AM

Solution

Add bool to the readmore docblock.

Impact

Minimal to none?

Usage Changes

No usage changes, to my knowlege.

Considerations

None come to mind.

Testing

I did not add tests. Not sure how to do so.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.294% when pulling 85ddda4 on gerardo-rodriguez:feature/readmore-allow-bool into e1460c0 on timber:master.

@jarednova jarednova added the 1.x label Jun 24, 2022
@nlemoine nlemoine requested review from gchtr and nlemoine as code owners May 17, 2023 08:12
@Levdbas Levdbas added 2.0 and removed 1.x labels Dec 13, 2023
@Levdbas Levdbas added this to the 2.0.1 milestone Dec 14, 2023
@Levdbas Levdbas modified the milestones: 2.0.1, 2.1.0 Feb 1, 2024
nlemoine
nlemoine approved these changes Feb 24, 2024
View reviewed changes
Copy link
Member
@nlemoine nlemoine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @gerardo-rodriguez, thanks for fixing the docblock!

@timber/rangers Note for future releases, this should be revised with actual types.

@nlemoine nlemoine merged commit 4e90b28 into timber:1.x Feb 24, 2024
Levdbas added a commit that referenced this pull request Feb 28, 2024
@Levdbas
Fix: allow Timber\PostExcerpt::read_more to accept bool value
ffeef57 
port of  #2578
@Levdbas Levdbas mentioned this pull request Feb 28, 2024
Merged
Levdbas added a commit that referenced this pull request May 15, 2024
@Levdbas @gchtr
Fix: allow Timber\PostExcerpt::read_more to accept bool value (#2937)
85e2a32 
* Fix: allow Timber\PostExcerpt::read_more to accept bool value

port of  #2578

* Update src/PostExcerpt.php

Co-authored-by: Lukas Gächter <lukas.gaechter@mind.ch>

---------

Co-authored-by: Lukas Gächter <lukas.gaechter@mind.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlemoine nlemoine nlemoine approved these changes

@jarednova jarednova Awaiting requested review from jarednova

@palmiak palmiak Awaiting requested review from palmiak 5F02

@gchtr gchtr Awaiting requested review from gchtr gchtr is a code owner

Assignees
No one assigned
Labels
2.0
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.
5 participants
@gerardo-rodriguez @coveralls @nlemoine @jarednova @Levdbas
0