8000 docs: Fix transform_value filter with `__return_true` by Jasonlgrd · Pull Request #3034 · timber/timber · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

docs: Fix transform_value filter with __return_true #3034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

Jasonlgrd
Copy link
Contributor
@Jasonlgrd Jasonlgrd commented Sep 1, 2024

Thanks for this package 🙏

I created this PR to just fix very little error in doc. I see it when I went copy/paste code from doc so I want fix that.

Issue

The filter value contains too many _
https://developer.wordpress.org/reference/functions/__return_true/

Solution

I have removed the underscore.

Impact

Nothing.

Usage Changes

Simplify copy/paste from doc.

Considerations

Testing

8000

@Jasonlgrd Jasonlgrd marked this pull request as ready for review September 1, 2024 22:44
@Jasonlgrd Jasonlgrd requested a review from gchtr as a code owner September 1, 2024 22:44
Copy link
Member
@gchtr gchtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thanks!

And thanks for taking the time to make a PR for this 🙌.

@gchtr gchtr merged commit 02d31d7 into timber:2.x Sep 2, 2024
@Jasonlgrd Jasonlgrd deleted the fix-transform-value-filter-docs branch September 2, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0