8000 Add protobuf generation; local docker-compose CRDs by jacobweinstock · Pull Request #22 · tinkerbell/tinkerbell · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add protobuf generation; local docker-compose CRDs #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jacobweinstock
Copy link
Member

Description

This allows for iterating on the protobuf definition. In the docker compose yaml, use local CRDs. This allows iterating on the CRDs. There is commented code for how to use GitHub versions.

Why is this needed

Fixes: #

How Has This Been Tested?

How are existing users impacted? What migration steps/scripts do we need?

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • provided instructions on how to upgrade

This allows iterating on the CRDs.
There is commented code for how to
use GitHub versions.

Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
This allows for iterating on the protobuf
definition.

Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
@jacobweinstock jacobweinstock merged commit de2bddb into tinkerbell:main Feb 11, 2025
2 checks passed
@jacobweinstock jacobweinstock deleted the add-protobuf-generation branch February 11, 2025 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0