Add API and Backend packages #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add constructor with some defaulting. Add code comments to public structs. Add validation of IPs and Ports. Handle case where all services are disabled. Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Backends implement just what Smee needs. Future Services will need the backends to support more functionality and it will be added then. Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Add mock client creation gets around not having a working kubeconfig or a kube api url. Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backends allow communicating with either the Kube or File backends. Some Smee updates were added as well.
Why is this needed
Fixes: #
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: