8000 uc8151: correct DrawBitmap() also refactor SendCommand() and SendData() for clarity by deadprogram · Pull Request #678 · tinygo-org/drivers · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

uc8151: correct DrawBitmap() also refactor SendCommand() and SendData() for clarity #678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 9, 2024
Merged

uc8151: correct DrawBitmap() also refactor SendCommand() and SendData() for clarity #678

merged 1 commit into from
May 9, 2024

Conversation

deadprogram
Copy link
Member

This PR improves the uc8151 implementation by both correcting an error in DrawBitmap() and also refactoring SendCommand() and SendData() for clarity.

@deadprogram
uc8151: correct DrawBitmap() also refactor SendCommand() and SendData…
bf4a391 
…() for clarity

Signed-off-by: deadprogram <ron@hybridgroup.com>
soypat
soypat approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor
@soypat soypat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable!

@deadprogram
Copy link
Member Author

Thanks for review @soypat now merging.

@deadprogram deadprogram merged commit 7dbca2a into dev May 9, 2024
1 check passed
@deadprogram deadprogram deleted the uc8151-displayer-improvements-2 branch May 9, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
< 5B14 div id="partial-discussion-sidebar" class="js-socket-channel js-updatable-content" data-channel="eyJjIjoicHVsbF9yZXF1ZXN0OjE4NjE4NzQ0MDUiLCJ0IjoxNzUwMjAwNjMzfQ==--84da0fca2fe2a20108781b177df9eb7d81fd3bb3c86e2949bb103acedc00b9bb" data-gid="PR_kwDOCWiw385u-fLl" data-channel-event-name="sidebar_updated" data-url="/tinygo-org/drivers/issues/678/show_partial?partial=issues%2Fsidebar" data-project-hovercards-enabled>
Reviewers

@soypat soypat soypat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deadprogram @soypat
0