Switch to score instead of worstCaseBacktrackCount
#637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
score instead of worstCaseBacktracksscore instead of worstCaseBacktrackCount
31362da to
eb6a9bf
Compare
| [/ab/, false, new Set(['missingAnchor'])], | ||
| [/(a+)+/, false, new Set(['missingAnchor'])], | ||
| [/a*a+/, false, new Set(['missingAnchor'])], |
| [/ab/, false, new Set(['missingAnchor'])], | ||
| [/(a+)+/, false, new Set(['missingAnchor'])], | ||
| [/a*a+/, false, new Set(['missingAnchor'])], | ||
| [/a*a{2,}/, false, new Set(['missingAnchor'])], |
| [/(a+)+/, false, new Set(['missingAnchor'])], | ||
| [/a*a+/, false, new Set(['missingAnchor'])], | ||
| [/a*a{2,}/, false, new Set(['missingAnchor'])], | ||
| [/a*aa/, false, new Set(['missingAnchor'])], |
| [/(a+)+/, true, new Set(['missingAnchor'])], | ||
| [/(a+)+$/, false, new Set(['missingAnchor'])], | ||
| [/(a+)+a/, false, new Set(['missingAnchor'])], | ||
| [/(a|aa)/, false, new Set(['missingAnchor'])], |
| [/a*aa/, false, new Set(['missingAnchor'])], | ||
| [/(a+)+/, true, new Set(['missingAnchor'])], | ||
| [/(a+)+$/, false, new Set(['missingAnchor'])], | ||
| [/(a+)+a/, false, new Set(['missingAnchor'])], |
There was a problem hiding this comment.
rxrx matches in 21 steps irrespective of n.
eb6a9bf to
3c44e92
Compare
This was referenced Dec 9, 2024
Closed
3c44e92 to
168581f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to
scoreinstead ofworstCaseBacktrackCountand fix some bugs.worstCaseBacktrackCountwasn't always accurate if there were any unbound quantifiers given we didn't know the max length of the input string.So now there's a more abstract
scoreinstead.Breaking changes
Library:
maxBacktracksconfig removedmaxScoreconfig addedworstCaseBacktrackCountremovedscoreaddedhitMaxBacktrackserror removedhitMaxScoreerror addedBacktrackCounttype removedScoretype addedCLI:
--maxBacktracksremoved--maxScoreaddedHow is
scorecalculated?1this means no backtracks can occur and for every possible input string the pattern could only match one way.closes #624
closes #621