Always stop expanding quantifier after min iterations after loop detected #651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cted ...unless the quantifier is part of a group that is referenced later. Previously if there was a max then we would always generate up to the max iterations. If the max was infinity then we would stop once the sequence of the left against right hit an infinite loop. Now we always stop when the sequence of left against right hits an infinite loop, once the min has been reached, unless it's part of a group referenced later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...unless the quantifier is part of a group that is referenced later.
Previously if there was a max then we would always generate up to the max iterations. If the max was infinity then we would stop once the sequence of the left against right hit an infinite loop.
Now we always stop when the sequence of left against right hits an infinite loop, once the min has been reached, unless it's part of a group referenced later.
Closes #650