-
Notifications
You must be signed in to change notification settings - Fork 159
Override optimization cflags set by users or build systems #169
base: master
Are you sure you want to change the base?
Conversation
0.3.0 release
Humble Bundle game icons fix
Small UI fixes
Game details view/dialog Games grid improvements Bug fixes
Added localizations: * pt_BR * pl * uk * de
Add Indonesian translation
* Update pt_BR.po
Show version for installed native GOG games Improve image rendering in AutoSizeImage
That should work. I'll wait for someone else to confirm it's working. |
I will test it it, but I'm not sure if I will be able to reproduce the original issue to check that the fix is doing something... |
@neuromancer Not sure if this is the default in Arch, but I think it is in Antergos (which I'm using). I think Also the gamehub-git package was just updated so it unsets CFLAGS, so if you use that as a base, the unset statements should be removed for the test. |
I tested all the variations of the CFLAGS (including |
Yeah, I agree. Optimally this shouldn't be needed (but the issue is too serious not to do something) |
This overrides optimization CFLAGS set in build system, and possibly user settings.
Hopefully this can avoid #99 / #103 / #112 / #162 at least a bit.
Perhaps @neuromancer could verify this works for him too? I originally used your tip to unset cflags completely, but I think this way is better as a general advice.