Default to old key handler #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kadler
reviewed
May 1, 2025
This might be disabled/enableed permamently in the future, just adding for parity.
"old" key handling uses curses to handle special keys; "new" key handling uses termcap to discover special keys and handles them itself. I'm not sure why it does its own key handling, since the code is far more complex and error prone - old and busted curses implementations, perhaps? The "old" key handling seems much simpler, and makes implementing things like mouse support much easier. It seems wiser to default to this, since modern terminals and curses implementations are much bettr about this sort of thing.
c17fc28 to
db0cdaf
Compare
kadler
reviewed
May 2, 2025
kadler
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of #36, at least for now. May want to cut 0.18 first before we remove it.