Add nRF52840DK-based Thread tutorial board definition #3979
Conversation
|
While I wish we didn't have to move code to a new file, this seems like a necessary step forward. I think it is worth it to have a convention for supporting boards with shields/peripherals. Since we are pretty invested in the nrf52840dk, this seems like a good place to start. Can we merge the bin/lib split first? |
Yup, working on that right now! |
644b8db to
4a59e87
Compare
dda8843 to
6eb9b54
Compare
|
This should be ready as soon as CI passes. |
| 8 => &nrf52840_peripherals.gpio_port[Pin::P1_10], | ||
| 9 => &nrf52840_peripherals.gpio_port[Pin::P1_11], | ||
| // Avoid exposing the I2C pins to userspace, as these are used in | ||
| // some tutorials (e.g., `nrf52840dk-thread-tutorial`). | ||
| // | ||
| // In the future we might want to make this configurable. | ||
| // | ||
| // 8 => &nrf52840_peripherals.gpio_port[Pin::P1_10], | ||
| // 9 => &nrf52840_peripherals.gpio_port[Pin::P1_11], |
There was a problem hiding this comment.
Ah yes, the dark side of the moon.
There was a problem hiding this comment.
Yeah... This is a larger issue around composability right now though...
| [features] | ||
| default = ["screen_ssd1306"] | ||
| screen_ssd1306 = [] | ||
| screen_sh1106 = [] |
There was a problem hiding this comment.
Cargo features just do not work for us do they.
There was a problem hiding this comment.
😕 I know, do you feel like we should remove this? Really this is only such that we can still easily support users with the wrong model / develop using the other screen that we have.
|
Can we merge this today? I want to rebuild the tutorial VM image with this PR landed some time tomorrow. |
|
Merging as we need this for the tutorial, if this breaks anything we should feel free to revert afterwards. |
Pull Request Overview
This pull request adds a board definition for the nRR52840DK board we'll be using for the Thread tutorial at CPS-IoT Week. It's still a draft as we might need to add more things / split things out into other PRs.
Testing Strategy
Running the tutorial apps.
TODO or Help Wanted
boards/tutorials.lib/bincrate refactor in thenrf52840dkcrate into its own PR?Documentation Updated
/docs, or no updates are required.Formatting
make prepush.