nrf52840 IEEE802.15.4 driver drop corrupted packets #3985
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lschuermann
previously approved these changes
May 10, 2024
bradjc
previously approved these changes
May 10, 2024
Co-authored-by: Brad Campbell <bradjc5@gmail.com>
bradjc
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
The current nrf52840 15.4 radio driver checks the crc to detect packet corruption and passes corrupted packets up the network stack. This creates issues if the length field was corrupted and can lead to an indexing error.
This PR drops corrupted packets or packets that possess a length field longer than the max 15.4 packet length.
Testing Strategy
N/A
TODO or Help Wanted
N/A
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.