8000 arch/riscv/pmp: fix underflow in region_overlaps by lschuermann · Pull Request #4463 · tock/tock · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

arch/riscv/pmp: fix underflow in region_overlaps #4463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 13, 2025
Merged

arch/riscv/pmp: fix underflow in region_overlaps #4463

merged 1 commit into from
Jun 13, 2025

Conversation

lschuermann
Copy link
Member

Pull Request Overview

This PR fixes an underflow issue in the RISC-V PMP's region_overlaps method.

Reported-by: Vivien Rindisbacher vrindisbacher77@gmail.com
Fixes: #4462

Testing Strategy

N/A

TODO or Help Wanted

N/A

Documentation Updated

  • Updated the relevant files in /docs, or no updates are required.

Formatting

  • Ran make prepush.

@lschuermann
arch/riscv/pmp: fix underflow in region_overlaps
f4521f2 
Reported-by: Vivien Rindisbacher <vrindisbacher77@gmail.com>
Fixes: #4462
@github-actions github-actions bot added the risc-v RISC-V architecture label Jun 11, 2025
@lschuermann
Copy link
Member Author

I guess at this point, we might as well check the other arithmetic operations in this file for under/overflows. If I find some before this PR is merged I can tack them onto here, otherwise I'll open follow-ups.

@lschuermann lschuermann added the blocked Waiting on something, like a different PR or a dependency. label Jun 11, 2025
@lschuermann
Copy link
Member Author

Marking as blocked until I've had time to think through the logic and @vrindisbacher's latest comment here: #4462 (comment)

@lschuermann lschuermann removed the blocked Waiting on something, like a different PR or a dependency. label Jun 12, 2025
@lschuermann
Copy link
Member Author

Unblocked, this seems to be the correct fix as discussed in #4462.

@alevy alevy added this pull request to the merge queue Jun 13, 2025
Merged via the queue into master with commit a7cd927 Jun 13, 2025
21 checks passed
@alevy alevy deleted the dev/pmp-region-overlap-underflow branch June 13, 2025 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alevy alevy alevy approved these changes

@alistair23 alistair23 alistair23 approved these changes

Assignees

@hudson-ayers hudson-ayers

Labels
risc-v RISC-V architecture
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Underflow in risc-v pmp region_overlaps
4 participants
@lschuermann @alevy @alistair23 @hudson-ayers
0