boards: nrf52840dk: Make 15.4 stack optional; add raw 15.4 stack to tutorial board #4018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves the 15.4/udp stack into their own function in lib.rs which main.rs files can then use if they want. Unfortunately this gets more and more complicated as now the sub-boards need access to the alarm mux.
45896ca to
84e5c25
Compare
tyler-potyondy
approved these changes
Jun 6, 2024
|
I'm in favor of these changes since they seem to follow the lib.rs/main.rs design split. The in kernel 15.4/udp stack initialization is somewhat unwieldy and is more readable with this abstraction. |
alevy
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This moves the 15.4/udp stack into their own function in lib.rs which main.rs files can then use if they want.
Unfortunately this gets more and more complicated as now the sub-boards need access to the alarm mux.
Testing Strategy
travis
TODO or Help Wanted
Blocked on previous 15.4 PRs.
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.