kernel: process standard: stop in YieldedFor #4039
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `_` in a match burned us here. We wouldn't be able to stop a process while it is in the yield_for state. This refactors the states to make this cleaner, and removes the _ match so future state changes will lead to errors unless those states are handled.
alevy
approved these changes
Jun 19, 2024
ppannuto
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
Using
_in a match burned us here. We wouldn't be able to stop a process while it is in the yield_for state.This refactors the states to make this cleaner, and removes the _ match so future state changes will lead to errors unless those states are handled.
Also updated some comments in process.rs that had fallen slightly out of date.
Testing Strategy
I don't have an easy long-running yieldwaitfor to use to test this with, but it would be easy to test if we did.
TODO or Help Wanted
n/a
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.