nrf52: Expose SPI0 and TWI1 (and not TWI0 and SPI1) #4042
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SPI0 and TWI0 are the same peripheral, and SPI1 and TWI1 are the same peripheral. Boards cannot use both 0 or both 1 at the same time. The current default peripherals expose both, allowing boards to use two SPI or two TWI, and they must be careful to not use both 0 or both 1 peripherals. This changes the default to be more opinionated and only expose one spi and one twi. This avoids the problem entirely for boards that use the default peripherals. We can of course support other peripheral groups for users who need say 3 SPIs or 2 I2C peripherals.
ppannuto
approved these changes
Jun 21, 2024
lschuermann
approved these changes
Jun 23, 2024
hudson-ayers
approved these changes
Jun 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
The [SPIM|TWI]* peripherals on the nrf are the same hardware. Right now we have a runtime check (which doesn't actually error) to verify both are not used. This enforces the restriction at compile time.
We don't have any boards which are using both SPI0/1 or both TWI0/1 (TWI is more crucial as there are three spi devices). So this PR changes the default to expose only compatible devices.
Note, this doesn't prevent using both TWI or both SPI, it just requires not using the default peripheral struct.
Testing Strategy
Worked when I used the screen and flash on nrf52840dk.
TODO or Help Wanted
n/a
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.