Moving microbit_v2 away from openocd to probe-rs #4074
Conversation
Changed the makefile of the microbit_v2 to use probe-rs instead of openocd. Made some changes to the README.md file located in the same folder to reflect the modifications.
solving a small typo
fixing a typo
added a small installation guide for probe-rs to the README file
|
Marking as blocked on #4054. |
Changed the Makefile to also include the option of openocd, at least until we further move away from it. And changed the read me to provide the commands for both probe-rs and openocd.
Adding the use of enviroment variables in the makefile and making the necessary command changes in the README file.8000
|
This should wait on #4075. |
|
Now that #4075 is merge, @NegrilaRares can you adapt this? |
|
Instead of all of this, you could just add a # Licensed under the Apache License, Version 2.0 or the MIT License.
# SPDX-License-Identifier: Apache-2.0 OR MIT
# Copyright Tock Contributors 2024.
[default.general]
chip = "nRF52833_xxAA"which would then, if $ cargo flash --releaseor $ cargo embed --releaseNo need for anything in the |
|
so should we get rid of the make file completely or leave it as an option? |
I suggest leaving the makefile in place so users can use both. |
should the probe-rs options that were already integrated be left there or should they be removed? i believe keeping them is a good option ill change the readme file to add the cargo embed explenation tommorow |
|
decided to use cargo flash instead of cargo embed |
|
made cargo the default and kept probe-rs and openocd as options would like some feedback on how to go about the naming convention |
Co-authored-by: Leon Schuermann <leon@is.currently.online>
|
should only the cargo flash default be kept in the readme file? |
solving some spacing mistakes
|
Since you are working with this, how are you handling the fact that |
|
well this behaviour isnt anything new as the previous openocd method also gave the same results, removing the apps that were flashed previously |
|
Right, is that bothersome? I was surprised by this, and it makes for a poor new user experience, and I'm just wondering what your experience is. |
|
This is a bit rough right now if you don't have the tool: And then And then I'm not really sure why the guidance from cargo is so poor, but what are users intended to do and how do we communicate that? |
|
So, you are supposed to either follow the instructions in your last command and install using the curl'd shell script, install from your package manager ( $ cargo install probe-rs-toolsI agree this is a suboptimal experience, though it doesn't differ much from the |
Pull Request Overview
As a result of the pull request #4054 made by @alevy.
I've changed the
makefileof themicrobit_v2to useprobe-rsinstead of openocd.Made some changes to the
README.mdfile located in the same folder to reflect the modifications.Testing Strategy
This pull request was tested by manually running the
make flash-bootloader,make flashandmake flash-debugwith the newmakefileconfiguration.TODO or Help Wanted
This pull request still needs to change the troubleshooting commands to get rid of the need for
openocd.I would like to get feedback about this before changing all the boards.
@alevy i was wondering if it would be worth using
cargo flashinstead ofprobe-rsdirectly.Documentation Updated
/docs, or no updates are required.Formatting
make prepush.