-
Notifications
You must be signed in to change notification settings - Fork 747
rust: update nightly to 2025-02 #4348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b22deed
to
28c1fc7
Compare
Even without the psoc6 errors, we get an error with earlgrey:
It seems like maybe this is caused where there are "too many" registers defined in the registers struct macro. @lschuermann @hudson-ayers Do you know what changed in Rust? Are we supposed to fix something about the registers macro, have smaller registers mapping, or follow the guidance of the compiler error? Is there a reason we would do this piecemeal (ie set it for individual crates) versus somehow change the setting for the entire workspace? It would be nice if Rust provided some sort of pointer to info about this change if something that wasn't an error before suddenly becomes an error. |
Well, this used to be an issue before, and it just seems that some compiler internals have either changed the default recursion limits, or how many iterations the compiler spends / "thinks it spends" trying to expand this macro. Hence, I think this is effectively just this: #2941 (comment) tl;dr: we have a small PoC on how to make this better, but we're still fundamentally recursive and wouldn't solve this issue for good. To me it still seems most promising to pursue #4001, which will completely supersede and deprecate this infrastructure, and not suffer from the same macro-rules restrictions and issues. |
This is needed for large register definitions.
Pull Request Overview
Update the nightly version. It's been three months.
@JADarius can you take a look at the CI build errors?Testing Strategy
Travis
TODO or Help Wanted
Many more clippy warnings to fix.
Documentation Updated
/docs
, or no updates are required.Formatting
make prepush
.