Fix large cache size #437
Merged
Fix large cache size #437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
Fixes #434 |
tommyxchow
requested changes
Apr 7, 2025
lib/cache_manager.dart
Outdated
| Config( | ||
| key, | ||
| stalePeriod: const Duration(days: 30), | ||
| maxNrOfCacheObjects: 500, |
There was a problem hiding this comment.
500 for maxNrOfCacheObjects seems too small, considering there can be hundreds of emotes and/or badges for each channel.
What do you think about 10,000? Seems like a good number to start with based on my rough estimate here: considering a 1GB image cache limit, if we assume an emote size of 100kb, 1,000,000 KB / 100 KB = 10,000 emotes. 7TV 4x emotes seem to be around 10-30 kb while GIFs are around 100-300 kb.
Suggested change
| maxNrOfCacheObjects: 500, | |
| maxNrOfCacheObjects: 10000, |
There was a problem hiding this comment.
I think you're right, 500 is too small. I mean the most important part is clearing images which wasn't used for more than 30 days.
tommyxchow
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's big problem with caching images in disk (cache on my release app exceeded 4GB). I find out that it's problem with caching library working under the hood of
cached_network_imagepackage (flutter_cache_manager).flutter_cache_manageris only clearing cache from files database, not from file system. So I fixed this in this PR by adding function to remove images which are not influtter_cache_manager's database. NOT TESTED ON IOS, but I think it should be fine.