bugs when someone sends invalid values #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
But that's the correct behaviour. Transactions with values under minimum or over maximum are treated as a donation. |
|
I don't think you understand. This is not the current behaviour. The javascript for the system stops working whenever one of those "donations" occur, because the it tries to manipulate a null value. The code i submited fixes this bug. Check it out. |
|
Okay, but can you at least rename new variables in index.php? 'tmp20140808' doesn't look very good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ponzi was breaking everytime someone sent values above the top limit. At first it wouldn't display anything, then, when i added checks for null/undefined fields. the values where all wrong. Figured out that the "amount" for those guys was accounted for, but not the "topay", which is always 0. I now ignore both.