10000 Conform the code to the lint rule. · Issue #853 · topolvm/topolvm · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Conform the code to the lint rule. #853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
4 tasks
llamerada-jp opened this issue Mar 12, 2024 · 1 comment
Open
4 tasks

Conform the code to the lint rule. #853

llamerada-jp opened this issue Mar 12, 2024 · 1 comment
Labels
keepalive

Comments

@llamerada-jp
Copy link
Contributor

What

This issue is a follow-up to #760.

We applied kubebuilder go/v4 template in #760, go/v4 template uses golangci-lint for linter and contains default lint rules. However, the rule is commented out because there are many violations in the existing code. Therefore, we want to update the code to conform to the rules.

How

Enable the lint rule and modify the code according to its warnings.

Checklist

  • Finish implementation of the issue
  • Test all functions
  • Have enough logs to trace activities
  • Notify developers of necessary actions
@llamerada-jp llamerada-jp mentioned this issue Mar 12, 2024
Closed
4 tasks
@toshipp toshipp mentioned this issue Apr 11, 2024
Merged
@github-actions GitHub Actions
Copy link
8000 Contributor

This issue has been automatically marked as stale because it has not had any activity for 30 days. It will be closed in a week if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Apr 11, 2024
@peng225 peng225 added keepalive and removed stale labels Apr 12, 2024
@toshipp toshipp moved this from To do to In progress in Development Apr 12, 2024
@satoru-takeuchi satoru-takeuchi moved this from In progress to Waiting in Development Apr 22, 2024
@satoru-takeuchi satoru-takeuchi moved this from Waiting to To do in Development Apr 22, 2024
llamerada-jp added a commit that referenced this issue Jul 24, 2024
@llamerada-jp
test: enable goconst linter
b086ad2 
issue: #853

Signed-off-by: Yuji Ito <llamerada.jp@gmail.com>
@llamerada-jp llamerada-jp mentioned this issue Jul 24, 2024
Merged
llamerada-jp added a commit that referenced this issue Jul 25, 2024
@llamerada-jp
test: enable goconst linter
4a60979 
issue: #853

Signed-off-by: Yuji Ito <llamerada.jp@gmail.com>
This was referenced Dec 19, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
keepalive
Projects
Development
Status: To do
Milestone
No milestone
Development

No branches or pull requests
2 participants
@llamerada-jp @peng225
0